Re: [PATCH] [submodule] Remove duplicate call to set_rev_name

2013-06-21 Thread Junio C Hamano
Heiko Voigt hvo...@hvoigt.net writes: Hi, On Mon, Jun 17, 2013 at 11:55:36AM +0200, Fredrik Gustafsson wrote: set_rev_name is a possible expensive operation. If a submodule has changes in it, set_rev_name was called twice. Solution is to move set_rev_name so it's only called once, no

Re: [PATCH] [submodule] Remove duplicate call to set_rev_name

2013-06-20 Thread Heiko Voigt
Hi, On Mon, Jun 17, 2013 at 11:55:36AM +0200, Fredrik Gustafsson wrote: set_rev_name is a possible expensive operation. If a submodule has changes in it, set_rev_name was called twice. Solution is to move set_rev_name so it's only called once, no matter the codepath taken. Looks good to

[PATCH] [submodule] Remove duplicate call to set_rev_name

2013-06-17 Thread Fredrik Gustafsson
set_rev_name is a possible expensive operation. If a submodule has changes in it, set_rev_name was called twice. Solution is to move set_rev_name so it's only called once, no matter the codepath taken. Signed-off-by: Fredrik Gustafsson iv...@iveqy.com --- git-submodule.sh | 4 ++-- 1 file