On Tue, Mar 4, 2014 at 5:27 PM, Eric Sunshine wrote:
> On Tue, Mar 4, 2014 at 10:54 AM, Karthik Nayak wrote:
>> diff --git a/commit.c b/commit.c
>> index 6bf4fe0..71a03e3 100644
>> --- a/commit.c
>> +++ b/commit.c
>> @@ -,11 +1114,11 @@ int parse_signed_commit(const unsigned char *sha1,
>>
On Tue, Mar 4, 2014 at 5:27 PM, Eric Sunshine wrote:
> On Tue, Mar 4, 2014 at 10:54 AM, Karthik Nayak wrote:
>> diff --git a/commit.c b/commit.c
>> index 6bf4fe0..71a03e3 100644
>> --- a/commit.c
>> +++ b/commit.c
>> @@ -1193,10 +1196,8 @@ static void parse_gpg_output(struct signature_check
>> *
On Tue, Mar 4, 2014 at 12:58 PM, karthik nayak wrote:
> Hey Tanay,
>
> 1. Yes just getting used to git send-email now, should follow that from now
> 2. I thought it shouldn't be a part of the commit, so i put it after
> the last ---
> 3. I did have a thought on your lines also , but concluded to i
Thanks for the resend. Etiquette on this list is to cc: people who
commented on previous versions of the submission. As Tanay already
mentioned, use [PATCH vN] in the subject where N is the version number
of this attempt. The -v option of "git format-email" can help.
More below.
On Tue, Mar 4, 20
Hey Tanay,
1. Yes just getting used to git send-email now, should follow that from now
2. I thought it shouldn't be a part of the commit, so i put it after
the last ---
3. I did have a thought on your lines also , but concluded to it being
more advantageous, you might be right though
Nice to hear
Karthik Nayak gmail.com> writes:
>
> In record_author_date() :
> Replace "buf + strlen(author )" by skip_prefix(), which is
> saved in a new "const char" variable "indent_line".
>
> In parse_signed_commit() :
> Replace "line + gpg_sig_header_len" by skip_prefix(), which
> is saved in a new "co
In record_author_date() :
Replace "buf + strlen(author )" by skip_prefix(), which is
saved in a new "const char" variable "indent_line".
In parse_signed_commit() :
Replace "line + gpg_sig_header_len" by skip_prefix(), which
is saved in a new "const char" variable "indent_line".
In parse_gpg_outpu
On Mon, Mar 3, 2014 at 10:23 AM, karthik nayak wrote:
> Hello Eric,
> Thanks for Pointing out everything, i had a thorough look and fixed a
> couple of things.
> Here is an Updated Patch.
> - Removed unnecessary code and variables.
> - Replaced all instances of starts_with() with skip_prefix()
Th
Hello Eric,
Thanks for Pointing out everything, i had a thorough look and fixed a
couple of things.
Here is an Updated Patch.
- Removed unnecessary code and variables.
- Replaced all instances of starts_with() with skip_prefix()
Replace starts_with() with skip_prefix() for better reading purposes.
Thanks for the submission. Some commentary below to expose you to the
review process on this project...
On Mon, Mar 3, 2014 at 2:47 AM, Karthik Nayak wrote:
> Replace with skip_prefix(), which uses the inbuilt function
> strcmp() to compare.
Explaining the purpose of the change is indeed importa
Replace with skip_prefix(), which uses the inbuilt function
strcmp() to compare.
Other Places were this can be implemented:
commit.c : line 1117
commit.c : line 1197
Signed-off-by: Karthik Nayak
---
commit.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/commit.c b/commit
11 matches
Mail list logo
