Re: [PATCH 1/2] git-prompt.sh: strip unnecessary space in prompt string

2013-05-13 Thread Ramkumar Ramachandra
Junio C Hamano wrote: It is like asking why typeset a space after a sentence a tad wider than a space after each word: Not at all. The prompt has nothing to do with sentences. grouping related things together, and separating groups of different kind apart, to make it more readable. You

Re: [PATCH 1/2] git-prompt.sh: strip unnecessary space in prompt string

2013-05-13 Thread SZEDER Gábor
On Mon, May 13, 2013 at 03:43:43PM +0530, Ramkumar Ramachandra wrote: SZEDER Gábor wrote: Don't forget that others might use a different prompt format and using colors in the prompt is optional. With the default prompt format and without colors I find that that space definitely helps

Re: [PATCH 1/2] git-prompt.sh: strip unnecessary space in prompt string

2013-05-13 Thread SZEDER Gábor
On Mon, May 13, 2013 at 01:05:51PM +0200, SZEDER Gábor wrote: On Mon, May 13, 2013 at 03:43:43PM +0530, Ramkumar Ramachandra wrote: If we can agree that it's just a matter of taste, we should both be able to have what we want. Any suggestions on how to make this configurable? The same

Re: [PATCH 1/2] git-prompt.sh: strip unnecessary space in prompt string

2013-05-13 Thread Junio C Hamano
SZEDER Gábor sze...@ira.uka.de writes: On Mon, May 13, 2013 at 01:05:51PM +0200, SZEDER Gábor wrote: On Mon, May 13, 2013 at 03:43:43PM +0530, Ramkumar Ramachandra wrote: If we can agree that it's just a matter of taste, we should both be able to have what we want. Any suggestions on how

Re: [PATCH 1/2] git-prompt.sh: strip unnecessary space in prompt string

2013-05-13 Thread Ramkumar Ramachandra
Junio C Hamano wrote: If you restructure the code to formulate gitstring to call a shell function to do so, people can override it and come up with whatever format they want to use, no? The user would essentially have to implement her own __git_ps1_colorize_string; a function that takes a lot

Re: [PATCH 1/2] git-prompt.sh: strip unnecessary space in prompt string

2013-05-12 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: Nobody has branch names that end with + or *. Then why put a space after the branch name and before [*|+][=||] in the prompt string? I do not think the space is for disambiguation. It is like asking why typeset a space after a sentence a tad

[PATCH 1/2] git-prompt.sh: strip unnecessary space in prompt string

2013-05-11 Thread Ramkumar Ramachandra
Nobody has branch names that end with + or *. Then why put a space after the branch name and before [*|+][=||] in the prompt string? Before this, your prompt might have looked like: artagnon|master *=:~/src/git$ Now, it will look like: artagnon|master*=:~/src/git$ Signed-off-by: