Re: [PATCH 3/3] make commit --verbose work with --no-status

2014-02-24 Thread Jeff King
On Mon, Feb 24, 2014 at 12:24:42PM +0800, Tay Ray Chuan wrote: What happens here when there is an alternate status format _and_ --verbose is used? If I say git commit --porcelain it should imply --dry-run. But git commit --porcelain --verbose no longer does so after your patch. I

Re: [PATCH 3/3] make commit --verbose work with --no-status

2014-02-23 Thread Tay Ray Chuan
On Sat, Feb 22, 2014 at 4:31 PM, Jeff King p...@peff.net wrote: On Sat, Feb 22, 2014 at 03:09:22AM +0800, Tay Ray Chuan wrote: @@ -1141,7 +1146,12 @@ static int parse_and_validate_options(int argc, const char *argv[], if (all argc 0) die(_(Paths with -a does not make

Re: [PATCH 3/3] make commit --verbose work with --no-status

2014-02-22 Thread Jeff King
On Sat, Feb 22, 2014 at 03:09:22AM +0800, Tay Ray Chuan wrote: @@ -1141,7 +1146,12 @@ static int parse_and_validate_options(int argc, const char *argv[], if (all argc 0) die(_(Paths with -a does not make sense.)); - if (status_format != STATUS_FORMAT_DEFAULT) +

[PATCH 3/3] make commit --verbose work with --no-status

2014-02-21 Thread Tay Ray Chuan
One would expect 'git commit --verbose --no-status' to give a commit message with a diff of the commit, sans the output of git-status. However, this does not work currently; the commit message body is entirely empty (diff is absent as well). This is because internally the status machinery is used