Junio C Hamano wrote:
we can silence Perlcritique, even though we do not gain much safety
by doing so.
Nit: it's perlcritic; critique is used to refer to the output of a critic.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
From: Ramkumar Ramachandra artag...@gmail.com
Perlcritic does not want to see the trailing pipe in the two-args
form of open(), i.e.
open my $fh, $cmd \Q$file\E |;
If $cmd were a single-token command name, it would make a lot more
sense to use four-or-more-args form open
Junio C Hamano wrote:
we cannot rewrite it to
open my $fh, -|, $cmd, $file;
for extra safety. At least, by using this in the three-arg form:
open my $fh, -|, $cmd \Q$file\E;
we can silence Perlcritique, even though we do not gain much safety
by doing so.
3 matches
Mail list logo
