Re: [PATCH 9/9] rebase -i: rearrange fixup/squash lines using the rebase--helper

2016-09-04 Thread Johannes Schindelin
Hi Josh, On Sat, 3 Sep 2016, Josh Triplett wrote: > On Fri, Sep 02, 2016 at 06:23:42PM +0200, Johannes Schindelin wrote: > > Let's reimplement this with linear complexity (using a hash map to > > match the commits' subject lines) for the common case; Sadly, the > > fixup/squash feature's design

Re: [PATCH 9/9] rebase -i: rearrange fixup/squash lines using the rebase--helper

2016-09-03 Thread Josh Triplett
On Fri, Sep 02, 2016 at 06:23:42PM +0200, Johannes Schindelin wrote: > Let's reimplement this with linear complexity (using a hash map to > match the commits' subject lines) for the common case; Sadly, the > fixup/squash feature's design neglected performance considerations, > allowing arbitrary

[PATCH 9/9] rebase -i: rearrange fixup/squash lines using the rebase--helper

2016-09-02 Thread Johannes Schindelin
This operation has quadratic complexity, which is especially painful on Windows, where shell scripts are *already* slow (mainly due to the overhead of the POSIX emulation layer). Let's reimplement this with linear complexity (using a hash map to match the commits' subject lines) for the common