Re: [PATCH v2] stash: handle specifying stashes with spaces

Thomas Rast tr at thomasrast.ch writes: I wonder what we would lose by dropping the --symbolic in the line I quoted above (which is the second parsing pass), so that it resolves to a SHA1. We would gain some robustness, as I'm not sure $REV: works correctly in the face of weird revision

[PATCH v2] stash: handle specifying stashes with spaces

When trying to pop/apply a stash specified with an argument containing spaces git-stash will throw an error: $ git stash pop 'stash@{two hours ago}' Too many revisions specified: stash@{two hours ago} This happens because word splitting is used to count non-option arguments. Make use of

Re: [PATCH v2] stash: handle specifying stashes with spaces

Thanks for looking into this! Øystein Walle oys...@gmail.com writes: - REV=$(git rev-parse --quiet --symbolic --verify $1 2/dev/null) || { + REV=$(git rev-parse --quiet --symbolic --verify $1 2/dev/null) || { reference=$1 It's somewhat ironic that the one place where