Re: [PATCH v2 0/3] diff-highlight: add support for git log --graph output.

On Fri, Aug 19, 2016 at 09:19:44PM +, Eric Wong wrote: > > I've rebased my changes. Unfortunately, having 3 commits made this somewhat > > tedious. I also find it weird that my new patch set makes it difficult to > > see > > what changes I've made from my first set. What's the standard

Re: [PATCH v2 0/3] diff-highlight: add support for git log --graph output.

Brian Henderson wrote: > On Wed, Aug 10, 2016 at 08:56:35AM +, Eric Wong wrote: > > "local" is not a portable construct. It's common for > > Debian/Ubuntu systems to use dash as /bin/sh instead of bash; > > (dash is faster, and mostly sticks to POSIX) > > > > The

[PATCH v2 0/3] diff-highlight: add support for git log --graph output.

Changes made per Eric. On Wed, Aug 10, 2016 at 08:56:35AM +, Eric Wong wrote: > Brian Henderson wrote: > > Hi Brian, > > A few minor portability/style nits below, but contrib/ probably > (still?) has laxer rules than the rest of git... > > I think we still require