Re: [PATCH v2 26/27] struct ref_update: Add type field

Junio C Hamano gits...@pobox.com writes: I wonder if ref-transaction-commit can shrink its parameter list by accepting a single pointer to one ref_update? Disregard this one. I was fooled into thinking that the function is called with parameters such as update-old_sha1, update_flags,

Re: [PATCH v2 26/27] struct ref_update: Add type field

Michael Haggerty mhag...@alum.mit.edu writes: This is temporary space for ref_transaction_commit(). Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- I was about to complain to *Add* type that does not say what it is used for at all, with Please do not add something for unknown

[PATCH v2 26/27] struct ref_update: Add type field

This is temporary space for ref_transaction_commit(). Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- refs.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/refs.c b/refs.c index d1edd57..07f900a 100644 --- a/refs.c +++ b/refs.c @@ -3279,6 +3279,7 @@ struct