Re: [PATCH v3 1/2] diff: add --line-prefix option for passing in a prefix

2016-08-10 Thread Jacob Keller
On Wed, Aug 10, 2016 at 2:58 PM, Junio C Hamano wrote: > Jacob Keller writes: > >> As suggested by Junio, I implemented --line-prefix to enable the graph >> display correctly. This works by a neat trick of adding to the msgbuf, >> so no code needs to

Re: [PATCH v3 1/2] diff: add --line-prefix option for passing in a prefix

2016-08-10 Thread Jacob Keller
On Wed, Aug 10, 2016 at 2:58 PM, Junio C Hamano wrote: > You might be envisioning a future enhancement where the recursive > one uses not "-Submodule commit A"/"-Submodule commit B", and not > "diff A B", but "log -p A...B" in the submodule, and in such a case, > it might make

Re: [PATCH v3 1/2] diff: add --line-prefix option for passing in a prefix

2016-08-10 Thread Junio C Hamano
Jacob Keller writes: > As suggested by Junio, I implemented --line-prefix to enable the graph > display correctly. This works by a neat trick of adding to the msgbuf, > so no code needs to be altered. I presumed that the line prefix should > go *after* the graphs own

[PATCH v3 1/2] diff: add --line-prefix option for passing in a prefix

2016-08-10 Thread Jacob Keller
From: Jacob Keller This will be used by a future patch which implements a diff mode for submodule display. Without this, the diff output would incorrectly display when using both -p and --graph during a git-log. Signed-off-by: Jacob Keller --- As