Re: [PATCHv2] push: change submodule default to check

On Wed, Aug 24, 2016 at 03:37:29PM -0700, Stefan Beller wrote: > > That sounds massively ... broken. So before even thinking about > > flipping it to default, this needs to be fixed first. > > I agree. That sounds bad. > > However having the --auto-check feels like papering over the > actual

Re: [PATCHv2] push: change submodule default to check

On Wed, Aug 24, 2016 at 12:37 PM, Junio C Hamano wrote: > Jeff King writes: > > This seems to be dropped from the list, probably due to no "To:" > header in the original, which led to "no", "To-header" "on" and > "input <" on YOUR recipient list, so I am quoting

Re: [PATCHv2] push: change submodule default to check

Junio C Hamano writes: > Jeff King writes: > >> For instance, try this from a checkout of linux.git: >> >> for i in no check; do >> rm -rf dst.git >> git init --bare dst.git >> echo "==> Pushing with submodules=$i" >> time git push

Re: [PATCHv2] push: change submodule default to check

Jeff King writes: This seems to be dropped from the list, probably due to no "To:" header in the original, which led to "no", "To-header" "on" and "input <" on YOUR recipient list, so I am quoting it in full without trimming. > On Wed, Aug 24, 2016 at 10:30:17AM -0700, Stefan

Re: [PATCHv2] push: change submodule default to check

Stefan Beller writes: > When working with submodules, it is easy to forget to push the submodules. > The setting 'check', which checks if any existing submodule is present on > at least one remote of the submodule remotes, is designed to prevent this > mistake. > > Flipping

[PATCHv2] push: change submodule default to check

When working with submodules, it is easy to forget to push the submodules. The setting 'check', which checks if any existing submodule is present on at least one remote of the submodule remotes, is designed to prevent this mistake. Flipping the default to check for submodules is safer than the