[PATCHv2 1/7] t4030: demonstrate behavior of show with textconv

2013-04-23 Thread Michael J Gruber 
git show commit honors the textconv setting while git show blob
does not. Demonstrate this in the test.

Signed-off-by: Michael J Gruber g...@drmicha.warpmail.net
---
 t/t4030-diff-textconv.sh | 12 
 1 file changed, 12 insertions(+)

diff --git a/t/t4030-diff-textconv.sh b/t/t4030-diff-textconv.sh
index 53ec330..260ea92 100755
--- a/t/t4030-diff-textconv.sh
+++ b/t/t4030-diff-textconv.sh
@@ -58,6 +58,12 @@ test_expect_success 'diff produces text' '
test_cmp expect.text actual
 '
 
+test_expect_success 'show commit produces text' '
+   git show HEAD diff 
+   find_diff diff actual 
+   test_cmp expect.text actual
+'
+
 test_expect_success 'diff-tree produces binary' '
git diff-tree -p HEAD^ HEAD diff 
find_diff diff actual 
@@ -84,6 +90,12 @@ test_expect_success 'status -v produces text' '
git reset --soft HEAD@{1}
 '
 
+test_expect_failure 'show blob produces text' '
+   git show HEAD:file actual 
+   printf 0\\n1\\n expect 
+   test_cmp expect actual
+'
+
 test_expect_success 'grep-diff (-G) operates on textconv data (add)' '
echo one expect 
git log --root --format=%s -G0 actual 
-- 
1.8.2.1.799.g1ac2534

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2 1/7] t4030: demonstrate behavior of show with textconv

2013-04-23 Thread Junio C Hamano 
Michael J Gruber g...@drmicha.warpmail.net writes:

 git show commit honors the textconv setting while git show blob
 does not. Demonstrate this in the test.

Should git show blob run textconv by default?  I somehow had an
impression that people were against it during the discussion on the
previous round.


 Signed-off-by: Michael J Gruber g...@drmicha.warpmail.net
 ---
  t/t4030-diff-textconv.sh | 12 
  1 file changed, 12 insertions(+)

 diff --git a/t/t4030-diff-textconv.sh b/t/t4030-diff-textconv.sh
 index 53ec330..260ea92 100755
 --- a/t/t4030-diff-textconv.sh
 +++ b/t/t4030-diff-textconv.sh
 @@ -58,6 +58,12 @@ test_expect_success 'diff produces text' '
   test_cmp expect.text actual
  '
  
 +test_expect_success 'show commit produces text' '
 + git show HEAD diff 
 + find_diff diff actual 
 + test_cmp expect.text actual
 +'
 +
  test_expect_success 'diff-tree produces binary' '
   git diff-tree -p HEAD^ HEAD diff 
   find_diff diff actual 
 @@ -84,6 +90,12 @@ test_expect_success 'status -v produces text' '
   git reset --soft HEAD@{1}
  '
  
 +test_expect_failure 'show blob produces text' '
 + git show HEAD:file actual 
 + printf 0\\n1\\n expect 
 + test_cmp expect actual
 +'
 +
  test_expect_success 'grep-diff (-G) operates on textconv data (add)' '
   echo one expect 
   git log --root --format=%s -G0 actual 
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html