[PATCHv2 8/8] reflog: use parse_config_key in config callback

2013-01-22 Thread Jeff King
This doesn't save any lines, but does keep us from doing error-prone pointer arithmetic with constants. Signed-off-by: Jeff King p...@peff.net --- builtin/reflog.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/builtin/reflog.c b/builtin/reflog.c index

Re: [PATCHv2 8/8] reflog: use parse_config_key in config callback

2013-01-22 Thread Junio C Hamano
Jeff King p...@peff.net writes: This doesn't save any lines, but does keep us from doing error-prone pointer arithmetic with constants. Yeah, this and 7/8 shows that the true value of the new parse function is not line number reduction but clarity of the calling code. There is really no point