Re: [PATCH] Change git-branch to list branches

2005-08-17 Thread Kalle Valo
Kalle Valo <[EMAIL PROTECTED]> writes:

> Junio C Hamano <[EMAIL PROTECTED]> writes:
>
>> I do not think we have agreed to limit ourselves to a flat
>> namespace under refs/heads without subdirectories.  Something
>> like what git-show-branches-script does when $# == 0, perhaps?
>
> I didn't realise this. I'll send a revised patch soon.

Ah, but you fixed it already. Thanks!

-- 
Kalle Valo

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Change git-branch to list branches

2005-08-17 Thread Kalle Valo
Junio C Hamano <[EMAIL PROTECTED]> writes:

> I do not think we have agreed to limit ourselves to a flat
> namespace under refs/heads without subdirectories.  Something
> like what git-show-branches-script does when $# == 0, perhaps?

I didn't realise this. I'll send a revised patch soon.

-- 
Kalle Valo

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Change git-branch to list branches

2005-08-16 Thread Junio C Hamano
Kalle Valo <[EMAIL PROTECTED]> writes:

> If no argument provided to `git branch`, show available branches and
> mark current branch with star.

I like the general direction, but this particular implementation
may be a bit troublesome.

> +if [ -z "$branchname" ]; then
> +current=$(basename $(readlink $GIT_DIR/HEAD))
> +cd $GIT_DIR/refs/heads &&
> +ls | sed -e "s/^/  /" -e "s/  $current/* $current/"
> +exit
> +fi

I do not think we have agreed to limit ourselves to a flat
namespace under refs/heads without subdirectories.  Something
like what git-show-branches-script does when $# == 0, perhaps?


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html