Re: [PATCH] Makefile: suppress false positive warnings of empty format string.

2013-09-30 Thread Jeff King
On Sun, Sep 29, 2013 at 12:00:17PM -0700, Jonathan Nieder wrote: --- a/Makefile +++ b/Makefile @@ -349,7 +349,7 @@ GIT-VERSION-FILE: FORCE # CFLAGS and LDFLAGS are for the users to override from the command line. -CFLAGS = -g -O2 -Wall +CFLAGS = -g -O2 -Wall

Re: [PATCH] Makefile: suppress false positive warnings of empty format string.

2013-09-30 Thread Jonathan Nieder
Jeff King wrote: I think we'd be better off to simply mark up the few callsites. Workarounds are here: http://article.gmane.org/gmane.comp.version-control.git/230026 Yeah, that looks okay (ugly but tolerable). It's tempting to do something like

Re: [PATCH] Makefile: suppress false positive warnings of empty format string.

2013-09-30 Thread Jeff King
On Mon, Sep 30, 2013 at 02:26:36PM -0700, Jonathan Nieder wrote: Jeff King wrote: I think we'd be better off to simply mark up the few callsites. Workarounds are here: http://article.gmane.org/gmane.comp.version-control.git/230026 Yeah,

Re: [PATCH] Makefile: suppress false positive warnings of empty format string.

2013-09-30 Thread Stefan Beller
On 09/30/2013 10:14 PM, Jeff King wrote: On Sun, Sep 29, 2013 at 12:00:17PM -0700, Jonathan Nieder wrote: --- a/Makefile +++ b/Makefile @@ -349,7 +349,7 @@ GIT-VERSION-FILE: FORCE # CFLAGS and LDFLAGS are for the users to override from the command line. -CFLAGS = -g -O2 -Wall

Re: [PATCH] Makefile: suppress false positive warnings of empty format string.

2013-09-30 Thread Jeff King
On Mon, Sep 30, 2013 at 11:38:33PM +0200, Stefan Beller wrote: To be honest, I'm surprised that -Wall doesn't create problems for older cc implementations. We've had patches for compiling with antique SUNWspro and MIPSpro compilers, and I sort of assumed that those don't handle -Wall. But

Re: [PATCH] Makefile: suppress false positive warnings of empty format string.

2013-09-29 Thread Felipe Contreras
On Sun, Sep 29, 2013 at 7:08 AM, Stefan Beller stefanbel...@googlemail.com wrote: Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index de3d72c..60afa51 100644 --- a/Makefile +++

Re: [PATCH] Makefile: suppress false positive warnings of empty format string.

2013-09-29 Thread Ramsay Jones
On 29/09/13 16:07, Felipe Contreras wrote: On Sun, Sep 29, 2013 at 7:08 AM, Stefan Beller stefanbel...@googlemail.com wrote: Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index

Re: [PATCH] Makefile: suppress false positive warnings of empty format string.

2013-09-29 Thread Jonathan Nieder
Hi, Stefan Beller wrote: --- a/Makefile +++ b/Makefile @@ -349,7 +349,7 @@ GIT-VERSION-FILE: FORCE # CFLAGS and LDFLAGS are for the users to override from the command line. -CFLAGS = -g -O2 -Wall +CFLAGS = -g -O2 -Wall -Wno-format-zero-length Thanks for taking this on. Two