Re: [PATCH] Support long format for log-based submodule diff

On Sun, Apr 1, 2018 at 6:07 PM, Robert Dailey wrote: > On Tue, Mar 27, 2018 at 5:17 PM, Stefan Beller wrote: >>> >> $ git diff --submodule=log --submodule-log-detail=(long|short) >>> >> >>> >> I'm not sure what makes sense here. I welcome

Re: [PATCH] Support long format for log-based submodule diff

On Tue, Mar 27, 2018 at 5:17 PM, Stefan Beller wrote: >> >> $ git diff --submodule=log --submodule-log-detail=(long|short) >> >> >> >> I'm not sure what makes sense here. I welcome thoughts/discussion and >> >> will provide follow-up patches. >> > >> > The case of merges is

Re: [PATCH] Support long format for log-based submodule diff

> >> $ git diff --submodule=log --submodule-log-detail=(long|short) > >> > >> I'm not sure what makes sense here. I welcome thoughts/discussion and > >> will provide follow-up patches. > > > > The case of merges is usually configured with --[no-]merges, or > > --min-parents=. > But that is a knob

Re: [PATCH] Support long format for log-based submodule diff

Stefan Beller writes: >> $ git diff --submodule=log --submodule-log-detail=(long|short) >> >> I'm not sure what makes sense here. I welcome thoughts/discussion and >> will provide follow-up patches. > > The case of merges is usually configured with --[no-]merges, or >

Re: [PATCH] Support long format for log-based submodule diff

On Wed, Mar 7, 2018 at 1:11 PM, Robert Dailey wrote: > I am experimenting with a version of submodule diff (using log style) > that prints the commits brought in from merges, while excluding the > merge commits themselves. This is useful in cases where a merge commit's >

Re: [PATCH] Support long format for log-based submodule diff

Robert Dailey writes: > I could have gone through the effort to make this more configurable, but > before doing that level of work I wanted to get some discussion going to > understand first if this is a useful change and second how it should be > configured. For