Re: [PATCH] http.c: Add config options/parsing for SSL engine vars

2013-04-30 Thread Junio C Hamano
Does anybody familiar with the http codepath have comments on this? The authoritative source https://github.com/bagder/curl/blob/master/docs/libcurl/symbols-in-versions tells me that the CURLOPT_* used in this patch are available since cURL 7.9.3, but I see a #if LIBCURL_VERSION_NUM 0x070704

Re: [PATCH] http.c: Add config options/parsing for SSL engine vars

2013-04-30 Thread Jeff King
On Tue, Apr 30, 2013 at 09:45:44AM -0700, Junio C Hamano wrote: The authoritative source https://github.com/bagder/curl/blob/master/docs/libcurl/symbols-in-versions tells me that the CURLOPT_* used in this patch are available since cURL 7.9.3, but I see a #if LIBCURL_VERSION_NUM 0x070704

Re: [PATCH] http.c: Add config options/parsing for SSL engine vars

2013-04-30 Thread Jerry Qassar
On Tue, Apr 30, 2013 at 11:27 AM, Jeff King p...@peff.net wrote: On Tue, Apr 30, 2013 at 09:45:44AM -0700, Junio C Hamano wrote: The authoritative source https://github.com/bagder/curl/blob/master/docs/libcurl/symbols-in-versions tells me that the CURLOPT_* used in this patch are available

Re: [PATCH] http.c: Add config options/parsing for SSL engine vars

2013-04-30 Thread Junio C Hamano
Jerry Qassar jqas...@gmail.com writes: Curl already does support engine-based certificates (in code and help). Its problem is that a) it doesn't yet read your engine defs out of OpenSSL config, and b) a bug in copying the engine data, once that's patched, to the handle that calling apps use.

Re: [PATCH] http.c: Add config options/parsing for SSL engine vars

2013-04-30 Thread Jeff King
On Tue, Apr 30, 2013 at 01:04:17PM -0700, Jerry Qassar wrote: First, thanks very much for taking a look at this. I wasn't 100% certain about the versioning to use for it (specifically the version-to-0x mapping), so any input on that would be a big help. I'll try to answer your questions

Re: [PATCH] http.c: Add config options/parsing for SSL engine vars

2013-04-30 Thread Jeff King
On Tue, Apr 30, 2013 at 01:17:03PM -0700, Junio C Hamano wrote: Jerry Qassar jqas...@gmail.com writes: Curl already does support engine-based certificates (in code and help). Its problem is that a) it doesn't yet read your engine defs out of OpenSSL config, and b) a bug in copying the

Re: [PATCH] http.c: Add config options/parsing for SSL engine vars

2013-04-30 Thread Jerry Qassar
On Tue, Apr 30, 2013 at 1:29 PM, Jeff King p...@peff.net wrote: On Tue, Apr 30, 2013 at 01:17:03PM -0700, Junio C Hamano wrote: Jerry Qassar jqas...@gmail.com writes: Curl already does support engine-based certificates (in code and help). Its problem is that a) it doesn't yet read your