Re: [PATCH 04/11] tests: introduce test_ln_s and test_ln_s_add
Johannes Sixt wrote: > # - Use test_ln_s instead of "ln -s x y" when y has been added as a > # symbolic link entry earlier. Ah, sorry I skipped over the comments. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 04/11] tests: introduce test_ln_s and test_ln_s_add
Am 01.06.2013 13:11, schrieb Ramkumar Ramachandra:
> Johannes Sixt wrote:
>> +test_ln_s () {
>> + if test_have_prereq SYMLINKS
>> + then
>> + ln -s "$1" "$2"
>> + else
>> + printf '%s' "$1" >"$2"
>> + fi
>> +}
>
> What is this? We can't test_ln_s something and then 'git add' it, so
> what purpose does this serve?
Sure, we can 'git add' it:
# - Use test_ln_s instead of "ln -s x y" when y has been added as a
# symbolic link entry earlier.
-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 04/11] tests: introduce test_ln_s and test_ln_s_add
Johannes Sixt wrote:
> +test_ln_s_add () {
> + if test_have_prereq SYMLINKS
> + then
> + ln -s "$1" "$2" &&
> + git update-index --add "$2"
> + else
> + printf '%s' "$1" >"$2" &&
> + ln_s_obj=$(git hash-object -w "$2") &&
> + git update-index --add --cacheinfo 12 $ln_s_obj "$2"
> + fi
> +}
Nicely done. As far as git is concerned, a symlink is nothing but a
plain file containing the destination filename (minus the newline)
with mode 12 in the index.
> +test_ln_s () {
> + if test_have_prereq SYMLINKS
> + then
> + ln -s "$1" "$2"
> + else
> + printf '%s' "$1" >"$2"
> + fi
> +}
What is this? We can't test_ln_s something and then 'git add' it, so
what purpose does this serve?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
