Re: [PATCH 1/2] remote-helpers: tests: use python directly

2013-05-19 Thread Junio C Hamano
David Aguilar dav...@gmail.com writes: On Fri, May 17, 2013 at 7:12 PM, Junio C Hamano gits...@pobox.com wrote: So it is a right thing to do in that sense. I however am having this nagging feeling that I may be missing something subtle here. Comments from others are very much welcome.

Re: [PATCH 1/2] remote-helpers: tests: use python directly

2013-05-19 Thread Felipe Contreras
Junio C Hamano wrote: David Aguilar dav...@gmail.com writes: On Fri, May 17, 2013 at 7:12 PM, Junio C Hamano gits...@pobox.com wrote: So it is a right thing to do in that sense. I however am having this nagging feeling that I may be missing something subtle here. Comments from

Re: [PATCH 1/2] remote-helpers: tests: use python directly

2013-05-17 Thread David Aguilar
On Fri, May 17, 2013 at 7:12 PM, Junio C Hamano gits...@pobox.com wrote: Felipe Contreras felipe.contre...@gmail.com writes: These remote helpers use 'env python', not PYTHON_PATH, so that's where we should check for the extensions. Otherwise, if 'python' is not PYTHON_PATH (e.g.

Re: [PATCH 1/2] remote-helpers: tests: use python directly

2013-05-17 Thread Felipe Contreras
On Fri, May 17, 2013 at 9:51 PM, David Aguilar dav...@gmail.com wrote: On Fri, May 17, 2013 at 7:12 PM, Junio C Hamano gits...@pobox.com wrote: Felipe Contreras felipe.contre...@gmail.com writes: These remote helpers use 'env python', not PYTHON_PATH, so that's where we should check for the