Re: [PATCH 3/3] send-email: use the three-arg form of open in recipients_cmd

2013-04-02 Thread Ramkumar Ramachandra
Junio C Hamano wrote: we can silence Perlcritique, even though we do not gain much safety by doing so. Nit: it's perlcritic; critique is used to refer to the output of a critic. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org

Re: [PATCH 3/3] send-email: use the three-arg form of open in recipients_cmd

2013-03-31 Thread Jonathan Nieder
Junio C Hamano wrote: we cannot rewrite it to open my $fh, -|, $cmd, $file; for extra safety. At least, by using this in the three-arg form: open my $fh, -|, $cmd \Q$file\E; we can silence Perlcritique, even though we do not gain much safety by doing so.