Re: [PATCH 7/7] push: clarify rejection of update to non-commit-ish

2012-11-27 Thread Junio C Hamano
Chris Rorvick ch...@rorvick.com writes: With this code, the old must be a commit but new can be a tag that points at a commit? Why? The old must not be a tag because fast-forwarding from it is potentially destructive; a tag would likely be left dangling in this case. This is not true for

Re: [PATCH 7/7] push: clarify rejection of update to non-commit-ish

2012-11-26 Thread Junio C Hamano
Chris Rorvick ch...@rorvick.com writes: Pushes must already (by default) update to a commit-ish due the fast- forward check in set_ref_status_for_push(). But rejecting for not being a fast-forward suggests the situation can be resolved with a merge. Flag these updates (i.e., to a blob or a

Re: [PATCH 7/7] push: clarify rejection of update to non-commit-ish

2012-11-26 Thread Chris Rorvick
On Mon, Nov 26, 2012 at 12:53 PM, Junio C Hamano gits...@pobox.com wrote: Chris Rorvick ch...@rorvick.com writes: Pushes must already (by default) update to a commit-ish due the fast- forward check in set_ref_status_for_push(). But rejecting for not being a fast-forward suggests the