Re: [PATCH v9 08/11] trailer: add tests for git interpret-trailers
On Wed, Apr 2, 2014 at 12:54 AM, Junio C Hamano gits...@pobox.com wrote: +test_expect_success '--trim-empty without config' ' + cat expected -\EOF + ack: Peff + Acked-by: Johan + EOF + git interpret-trailers --trim-empty ack = Peff Reviewed-by Acked-by: Johan sob: actual + test_cmp expected actual +' Let's avoid these overlong and unreadable lines by doing something like this (just one hunk shown for illustration): ack: Peff Acked-by: Johan EOF - git interpret-trailers --trim-empty ack = Peff Reviewed-by Acked-by: Johan sob: actual + git interpret-trailers --trim-empty ack = Peff \ + Reviewed-by Acked-by: Johan sob: actual test_cmp expected actual ' Ok. I've queued the series on 'pu' with the 'chop-overlong-lines' and another minor fix squashed in; hopefully we can merge to 'next' soonish. Great! Thanks, Christian. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v9 08/11] trailer: add tests for git interpret-trailers
Junio C Hamano gits...@pobox.com writes: Christian Couder chrisc...@tuxfamily.org writes: +test_expect_success '--trim-empty without config' ' +cat expected -\EOF +ack: Peff +Acked-by: Johan +EOF +git interpret-trailers --trim-empty ack = Peff Reviewed-by Acked-by: Johan sob: actual +test_cmp expected actual +' Let's avoid these overlong and unreadable lines by doing something like this (just one hunk shown for illustration): ack: Peff Acked-by: Johan EOF - git interpret-trailers --trim-empty ack = Peff Reviewed-by Acked-by: Johan sob: actual + git interpret-trailers --trim-empty ack = Peff \ + Reviewed-by Acked-by: Johan sob: actual test_cmp expected actual ' I'll squash in the line-chopping fix to this, and also fill a missing whitespace in 3/11 before pushing it out to 'pu'. Hopefully the result can be later merged to 'next' without further rerolls. Thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v9 08/11] trailer: add tests for git interpret-trailers
Christian Couder chrisc...@tuxfamily.org writes: +test_expect_success '--trim-empty without config' ' + cat expected -\EOF + ack: Peff + Acked-by: Johan + EOF + git interpret-trailers --trim-empty ack = Peff Reviewed-by Acked-by: Johan sob: actual + test_cmp expected actual +' Let's avoid these overlong and unreadable lines by doing something like this (just one hunk shown for illustration): ack: Peff Acked-by: Johan EOF - git interpret-trailers --trim-empty ack = Peff Reviewed-by Acked-by: Johan sob: actual + git interpret-trailers --trim-empty ack = Peff \ + Reviewed-by Acked-by: Johan sob: actual test_cmp expected actual ' I've queued the series on 'pu' with the 'chop-overlong-lines' and another minor fix squashed in; hopefully we can merge to 'next' soonish. Thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
