Re: [PATCHv2 01/12] git p4 test: remove bash-ism of combined export/assignment

2012-09-17 Thread Luke Diamand
On 17/09/12 05:50, Junio C Hamano wrote: Luke Diamandl...@diamand.org writes: On 16/09/12 07:05, Junio C Hamano wrote: Luke Diamandl...@diamand.org writes: Looks good to me, ack. Thanks; is this an ack for the entire series, or are you expecting further back-and-forth with Pete before

Re: [PATCHv2 01/12] git p4 test: remove bash-ism of combined export/assignment

2012-09-16 Thread Junio C Hamano
Luke Diamand l...@diamand.org writes: Looks good to me, ack. Thanks; is this an ack for the entire series, or are you expecting further back-and-forth with Pete before the whole thing is ready? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to

Re: [PATCHv2 01/12] git p4 test: remove bash-ism of combined export/assignment

2012-09-16 Thread Luke Diamand
On 16/09/12 07:05, Junio C Hamano wrote: Luke Diamandl...@diamand.org writes: Looks good to me, ack. Thanks; is this an ack for the entire series, or are you expecting further back-and-forth with Pete before the whole thing is ready? An ack for the whole series. I'm just going through the

Re: [PATCHv2 01/12] git p4 test: remove bash-ism of combined export/assignment

2012-09-16 Thread Junio C Hamano
Luke Diamand l...@diamand.org writes: On 16/09/12 07:05, Junio C Hamano wrote: Luke Diamandl...@diamand.org writes: Looks good to me, ack. Thanks; is this an ack for the entire series, or are you expecting further back-and-forth with Pete before the whole thing is ready? An ack for the

Re: [PATCHv2 01/12] git p4 test: remove bash-ism of combined export/assignment

2012-09-15 Thread Luke Diamand
Looks good to me, ack. On 09/09/12 21:16, Pete Wyckoff wrote: Signed-off-by: Pete Wyckoffp...@padd.com --- t/lib-git-p4.sh | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh index 2d753ab..482eeac 100644 --- a/t/lib-git-p4.sh +++