RE: [feature request] git add completion should exclude staged content

2013-01-30 Thread Marc Khouzam
-Original Message- From: git-ow...@vger.kernel.org [mailto:git-ow...@vger.kernel.org] On Behalf Of Manlio Perillo Sent: Monday, January 28, 2013 3:16 PM To: Junio C Hamano Cc: Michael J Gruber; wookietreiber; git@vger.kernel.org Subject: Re: [feature request] git add completion

Re: [feature request] git add completion should exclude staged content

2013-01-30 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 30/01/2013 15:06, Marc Khouzam ha scritto: [...] I will try to update the patch, with your latest suggestions (avoid tricky POSIX shell syntax, and CDPATH issue - if I remember correctly), and with an update for the t/t9902-completion.sh test

RE: [feature request] git add completion should exclude staged content

2013-01-30 Thread Marc Khouzam
request] git add completion should exclude staged content -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 30/01/2013 15:06, Marc Khouzam ha scritto: [...] I will try to update the patch, with your latest suggestions (avoid tricky POSIX shell syntax, and CDPATH issue - if I remember

Re: [feature request] git add completion should exclude staged content

2013-01-30 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 30/01/2013 19:55, Marc Khouzam ha scritto: [...] The new logic in git-completion.bash tells bash that 'filenames' completion is ongoing so bash will add a '/' after directories. Sadly, tcsh won't do that, so it would be simpler if

Re: [feature request] git add completion should exclude staged content

2013-01-28 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 28/01/2013 00:00, Junio C Hamano ha scritto: wookietreiber kizkizzbangb...@googlemail.com writes: I have a feature request for `git add` auto completion: `git add` auto completion suggests all files / directories, filtered by nothing. I

Re: [feature request] git add completion should exclude staged content

2013-01-28 Thread Michael J Gruber
Manlio Perillo venit, vidit, dixit 28.01.2013 10:26: Il 28/01/2013 00:00, Junio C Hamano ha scritto: wookietreiber kizkizzbangb...@googlemail.com writes: I have a feature request for `git add` auto completion: `git add` auto completion suggests all files / directories, filtered by nothing.

Re: [feature request] git add completion should exclude staged content

2013-01-28 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 28/01/2013 13:52, Michael J Gruber ha scritto: Manlio Perillo venit, vidit, dixit 28.01.2013 10:26: Il 28/01/2013 00:00, Junio C Hamano ha scritto: wookietreiber kizkizzbangb...@googlemail.com writes: I have a feature request for `git add`

Re: [feature request] git add completion should exclude staged content

2013-01-28 Thread Michael J Gruber
Manlio Perillo venit, vidit, dixit 28.01.2013 15:02: Il 28/01/2013 13:52, Michael J Gruber ha scritto: Manlio Perillo venit, vidit, dixit 28.01.2013 10:26: Il 28/01/2013 00:00, Junio C Hamano ha scritto: wookietreiber kizkizzbangb...@googlemail.com writes: I have a feature request for `git

Re: [feature request] git add completion should exclude staged content

2013-01-28 Thread Junio C Hamano
Michael J Gruber g...@drmicha.warpmail.net writes: Manlio Perillo venit, vidit, dixit 28.01.2013 15:02: Please, test it and report any behaviour you think is incorrect. OK, that seems to work and to be quite helpful. Minor nit: git add -u could use the same fileset as git commit. But I

Re: [feature request] git add completion should exclude staged content

2013-01-28 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 28/01/2013 17:22, Michael J Gruber ha scritto: [...] The patch will suggest (for git add command), all the files that are candidate to be added to the index file. Please, test it and report any behaviour you think is incorrect. OK, that

Re: [feature request] git add completion should exclude staged content

2013-01-28 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 28/01/2013 18:52, Junio C Hamano ha scritto: [...] Thanks both for commenting. I'll find time to read it over again and perhaps we can merge it to 'next' and advertise it in the next issue of What's cooking report to ask for wider testing to