Re: [patch] fixup GECOS handling

2005-04-23 Thread Martin Schlemmer
On Fri, 2005-04-22 at 19:18 +0200, Petr Baudis wrote: Dear diary, on Fri, Apr 22, 2005 at 06:58:25PM CEST, I got a letter where Martin Schlemmer [EMAIL PROTECTED] told me that... Meaning, if they use a ',' in one of the fields (and it is a linux system with the chfn most probably from the

Re: [patch] fixup GECOS handling

2005-04-18 Thread Martin Schlemmer
On Mon, 2005-04-18 at 22:35 +1000, David Woodhouse wrote: On Mon, 2005-04-18 at 12:36 +0200, Martin Schlemmer wrote: realgecos[strchr(realgecos, ',') - realgecos] = '\0'; Er, *strchr(realgecos, ',') = 0; surely? Even if the compiler is clever enough to optimise out the gratuitous addition