Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly

2013-10-28 Thread Paolo Giarrusso
(Resending without HTML, so that it reaches the ML). On Fri, Oct 11, 2013 at 11:32 AM, Paolo Giarrusso p.giarru...@gmail.com wrote: On Wed, Oct 9, 2013 at 11:11 PM, Jonathan Nieder jrnie...@gmail.com wrote: Paolo Giarrusso wrote: Seeing the email, I wonder whether there's hope something

Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly

2013-10-09 Thread Johannes Sixt
Am 10/9/2013 12:32, schrieb Paolo Giarrusso: On Wed, Oct 9, 2013 at 12:20 PM, Tay Ray Chuan rcta...@gmail.com wrote: On Wed, Oct 9, 2013 at 11:57 AM, Paolo G. Giarrusso p.giarru...@gmail.com wrote: diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh index

Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly

2013-10-09 Thread Matthieu Moy
Paolo Giarrusso p.giarru...@gmail.com writes: Otherwise, one could change say to use printf, but that's more invasive. invasive in the sense that it impacts indirectly more callers, but are there really cases where echo is needed when calling say? Aren't there other potential bugs when

Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly

2013-10-09 Thread Paolo Giarrusso
On Wed, Oct 9, 2013 at 1:26 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Paolo Giarrusso p.giarru...@gmail.com writes: Otherwise, one could change say to use printf, but that's more invasive. invasive in the sense that it impacts indirectly more callers, but are there really cases

Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly

2013-10-09 Thread Jeff King
On Wed, Oct 09, 2013 at 02:03:24PM +0200, Paolo Giarrusso wrote: On Wed, Oct 9, 2013 at 1:26 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Paolo Giarrusso p.giarru...@gmail.com writes: Otherwise, one could change say to use printf, but that's more invasive. invasive in the