Re: [BUG] regarding `git add -p` and files containing wildcard characters

2016-12-08 Thread Jeff King
On Fri, Dec 09, 2016 at 04:46:49AM +0300, unixway.dr...@gmail.com wrote: > The problem is that `git-diff-files` does some globbing on the 'path' > arguments on its own and has no option to disable that (and > `git-add--interactive`'s `run_cmd_pipe` already handles all other sorts of > unsafe

[BUG] regarding `git add -p` and files containing wildcard characters

2016-12-08 Thread unixway . drive
`git add -p` behaves incorrectly if modified file contains any wildcard character. Consider 'random.diff' (attached). For this, interactive 'add' would first ask to add hunk with two diff headers (or with some "random" header at the end): $ git add -p diff --git a/Random * b/Random *