Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

Hi, On Tue, Jan 9, 2018 at 12:09 AM, Christian Couder wrote: > ... "i == cnt" is always false above. I think it should be "i == cnt - 1". uga. Thanks. That's stupid of me. > And with your code one can wonder why the cleanup is part of the loop. OK. I have

Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

Hi, On Mon, Jan 8, 2018 at 3:45 PM, Yasushi SHOJI wrote: > Hi all, > > Thank you guys for insightful help. I just read the code and now I understand > what you guys are saying. Yeah, I can say the fix is "spot on". > > But, to be honest, it's hard to see why you need

Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

Hi all, Thank you guys for insightful help. I just read the code and now I understand what you guys are saying. Yeah, I can say the fix is "spot on". But, to be honest, it's hard to see why you need "if (p)" at the first glance. So, how about this fix, instead? I also found a bug in

Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

Hi Yasushi, On Sat, Jan 6, 2018 at 3:27 PM, Yasushi SHOJI wrote: > best_bisection_sorted() seems to do > > - get the commit list along with the number of elements in the list > - walk the list one by one to check whether a element have TREESAME or not > - if

Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

On 6 January 2018 at 15:27, Yasushi SHOJI wrote: > best_bisection_sorted() seems to do > > - get the commit list along with the number of elements in the list > - walk the list one by one to check whether a element have TREESAME or not > - if TREESAME, skip > - if

Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

Hi Martin, Thank you for your comment. I haven't have time to read the code carefully so bare with me. On Sat, Jan 6, 2018 at 5:21 PM, Martin Ågren wrote: >> On Fri, Jan 5, 2018 at 11:45 AM, Yasushi SHOJI >> wrote: >>> When does the list

Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

> On Fri, Jan 5, 2018 at 11:45 AM, Yasushi SHOJI > wrote: >> When does the list allowed to contain NULLs? Short answer: there are no commits left to test. The list is built in the for-loop in `find_bisection()`. So the technical answer is: if all commits in the initial

Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

Yasushi SHOJI writes: > The patch (actually, I've tested the one in pu, 2e9fdc795cb27) avoids > the seg fault for sure, but the question is: > > When does the list allowed to contain NULLs? A very legitimate question. With the proposed log message alone, it is even

Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

Hi, On Fri, Jan 5, 2018 at 11:45 AM, Yasushi SHOJI wrote: > So that I can make a test case. OK, here is the step to reproduce on git.git $ git bisect start $ git bisect bad v2.16.0-rc0 $ git bisect good 0433d533f13671f4313c31e34707f0f5281a18e0 $ git bisect good $ git

Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

Hi, On Thu, Jan 4, 2018 at 3:26 AM, Martin Ågren wrote: > On 3 January 2018 at 15:21, Ævar Arnfjörð Bjarmason wrote: >> >> On Wed, Jan 03 2018, Yasushi SHOJI jotted: >> >>> Hi, >>> >>> git version 2.16.0.rc0 seg faults on my machine when I >>> [...] >>>

Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

On 3 January 2018 at 15:21, Ævar Arnfjörð Bjarmason wrote: > > On Wed, Jan 03 2018, Yasushi SHOJI jotted: > >> Hi, >> >> git version 2.16.0.rc0 seg faults on my machine when I >> [...] >> Program terminated with signal SIGSEGV, Segmentation fault. >> #0 0x55a73107f900 in

Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

On Wed, Jan 03 2018, Yasushi SHOJI jotted: > Hi, > > git version 2.16.0.rc0 seg faults on my machine when I > [...] > Program terminated with signal SIGSEGV, Segmentation fault. > #0 0x55a73107f900 in best_bisection_sorted (list=0x0, nr=0) at > bisect.c:232 > 232 free_commit_list(p->next);

[BUG] v2.16.0-rc0 seg faults when git bisect skip

Hi, git version 2.16.0.rc0 seg faults on my machine when I git bisect skip Here is a back trace: $ /opt/mygit/bin/git --version git version 2.16.0.rc0 $ /opt/mygit/bin/git bisect skip Segmentation fault (core dumped) $ gdb /opt/mygit/bin/git core GNU gdb (Debian 7.12-6+b1)