Re: [GSoC][PATCH v3] Make options that expect object ids less chatty if id is invalid

2018-03-06 Thread Paul-Sebastian Ungureanu
Hello Junio, Thank you for reviewing my code. I appreciate it. I made the changes here [1]. On Mon, 2018-03-05 at 16:19 -0800, Junio C Hamano wrote: > Taking these together, I _think_ this patch is moving things in the > right direction, in that it allows callers of parse_options_step() > to

Re: [GSoC][PATCH v3] Make options that expect object ids less chatty if id is invalid

2018-03-05 Thread Junio C Hamano
Paul-Sebastian Ungureanu writes: > Usually, the usage should be shown only if the user does not know what > options are available. If the user specifies an invalid value, the user > is already aware of the available options. In this case, there is no > point in

[GSoC][PATCH v3] Make options that expect object ids less chatty if id is invalid

2018-03-03 Thread Paul-Sebastian Ungureanu
Usually, the usage should be shown only if the user does not know what options are available. If the user specifies an invalid value, the user is already aware of the available options. In this case, there is no point in displaying the usage anymore. This patch applies to "git tag --contains",