Re: [GSoC][PATCH v4 2/2] submodule: port subcommand foreach from shell to C

2017-05-23 Thread Brandon Williams
On 05/23, Stefan Beller wrote: > On Tue, May 23, 2017 at 12:36 PM, Brandon Williams wrote: > > > > You can set .git_cmd = 1 instead. > > > >> + cpr.dir = list_item->name; > >> + prepare_submodule_repo_env(_array); > >> + > >> +

Re: [GSoC][PATCH v4 2/2] submodule: port subcommand foreach from shell to C

2017-05-23 Thread Stefan Beller
On Tue, May 23, 2017 at 12:36 PM, Brandon Williams wrote: > > You can set .git_cmd = 1 instead. > >> + cpr.dir = list_item->name; >> + prepare_submodule_repo_env(_array); >> + >> + argv_array_pushl(, "git", "--super-prefix", >> displaypath,

Re: [GSoC][PATCH v4 2/2] submodule: port subcommand foreach from shell to C

2017-05-23 Thread Brandon Williams
On 05/21, Prathamesh Chavan wrote: > This aims to make git-submodule foreach a builtin. This is the very > first step taken in this direction. Hence, 'foreach' is ported to > submodule--helper, and submodule--helper is called from git-submodule.sh. > The code is split up to have one function to

Re: [GSoC][PATCH v4 2/2] submodule: port subcommand foreach from shell to C

2017-05-23 Thread Brandon Williams
On 05/22, Stefan Beller wrote: > On Sun, May 21, 2017 at 5:58 AM, Prathamesh Chavan wrote: > > > I have also made some changes in git-submodule.sh for correcting > > the $path variable. And hence made the corresponding changes in > > the new test introduced in

Re: [GSoC][PATCH v4 2/2] submodule: port subcommand foreach from shell to C

2017-05-22 Thread Stefan Beller
On Sun, May 21, 2017 at 5:58 AM, Prathamesh Chavan wrote: > I have also made some changes in git-submodule.sh for correcting > the $path variable. And hence made the corresponding changes in > the new test introduced in t7407-submodule-foreach as well. > I have push this work

[GSoC][PATCH v4 2/2] submodule: port subcommand foreach from shell to C

2017-05-21 Thread Prathamesh Chavan
This aims to make git-submodule foreach a builtin. This is the very first step taken in this direction. Hence, 'foreach' is ported to submodule--helper, and submodule--helper is called from git-submodule.sh. The code is split up to have one function to obtain all the list of submodules. This