Re: [GSoC][PATCH v8 17/20] stash: convert save to builtin

2018-09-03 Thread Johannes Schindelin
Hi Eric, On Mon, 3 Sep 2018, Eric Sunshine wrote: > On Mon, Sep 3, 2018 at 2:44 PM Johannes Schindelin > wrote: > > where `strbuf_join_argv()` would be implemented like this (and I would put > > it into strbuf.c and strbuf.h: > > > > const char *strbuf_join_argv(struct strbuf *buf, > >

Re: [GSoC][PATCH v8 17/20] stash: convert save to builtin

2018-09-03 Thread Eric Sunshine
On Mon, Sep 3, 2018 at 2:44 PM Johannes Schindelin wrote: > where `strbuf_join_argv()` would be implemented like this (and I would put > it into strbuf.c and strbuf.h: > > const char *strbuf_join_argv(struct strbuf *buf, > int argc, const char **argv,

Re: [GSoC][PATCH v8 17/20] stash: convert save to builtin

2018-09-03 Thread Johannes Schindelin
Hi Paul, On Fri, 31 Aug 2018, Paul-Sebastian Ungureanu wrote: > Add stash save to the helper and delete functions which are no > longer needed (`show_help()`, `save_stash()`, `push_stash()`, > `create_stash()`, `clear_stash()`, `untracked_files()` and > `no_changes()`). > > The `-m` option is

[GSoC][PATCH v8 17/20] stash: convert save to builtin

2018-08-30 Thread Paul-Sebastian Ungureanu
Add stash save to the helper and delete functions which are no longer needed (`show_help()`, `save_stash()`, `push_stash()`, `create_stash()`, `clear_stash()`, `untracked_files()` and `no_changes()`). The `-m` option is no longer supported as it might not make sense to have two ways of passing a