Re: [PATCH/RFC] add--interactive: ignore all internal submodule changes

2018-01-11 Thread Duy Nguyen
On Thu, Jan 11, 2018 at 2:47 AM, Stefan Beller wrote: > On Wed, Jan 10, 2018 at 3:06 AM, Nguyễn Thái Ngọc Duy > wrote: >> For 'add -i' and 'add -p' the only action we can take on a dirty >> submodule entry (from the superproject perspective) is its SHA-1. The >> content changes inside do not mat

Re: [PATCH/RFC] add--interactive: ignore all internal submodule changes

2018-01-10 Thread Stefan Beller
On Wed, Jan 10, 2018 at 3:06 AM, Nguyễn Thái Ngọc Duy wrote: > For 'add -i' and 'add -p' the only action we can take on a dirty > submodule entry (from the superproject perspective) is its SHA-1. The > content changes inside do not matter, at least until interactive add has > --recurse-submodules

[PATCH/RFC] add--interactive: ignore all internal submodule changes

2018-01-10 Thread Nguyễn Thái Ngọc Duy
For 'add -i' and 'add -p' the only action we can take on a dirty submodule entry (from the superproject perspective) is its SHA-1. The content changes inside do not matter, at least until interactive add has --recurse-submodules or something. Ignore all dirty changes to reduce the questions 'add -