Re: [PATCH/RFC 0/5] add unset.variable for unsetting previously set variables

2014-10-13 Thread Junio C Hamano
Jeff King p...@peff.net writes: ... Which makes me wonder if safe-include is really helping that much versus a project shipping a shell script that munges the repository config. The latter is less safe (you are, after all, running code, but you would at least have the chance to examine it),

Re: [PATCH/RFC 0/5] add unset.variable for unsetting previously set variables

2014-10-10 Thread Jeff King
On Wed, Oct 08, 2014 at 12:52:24PM -0700, Junio C Hamano wrote: The whole reason why the actualy diff.*.command and textconv commands are defined in .git/config while the filetype label is assigned by in-tree .gitattributes is because these commands are platform dependant. So textconv on

Re: [PATCH/RFC 0/5] add unset.variable for unsetting previously set variables

2014-10-08 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: Junio C Hamano gits...@pobox.com writes: Jakub Narębski jna...@gmail.com writes: Junio C Hamano wrote: - [config] safe = section.variable will list variables that can be included with the config.safeInclude mechanism. Any variable

Re: [PATCH/RFC 0/5] add unset.variable for unsetting previously set variables

2014-10-08 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: I do not offhand think of a good example of an variable that we may want to allow overriding but still want to limit its values myself. I just thought of a semi-realistic use-case : diff.*.{command,textconv}. One may want to allow per-project sets of

Re: [PATCH/RFC 0/5] add unset.variable for unsetting previously set variables

2014-10-08 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: Junio C Hamano gits...@pobox.com writes: I do not offhand think of a good example of an variable that we may want to allow overriding but still want to limit its values myself. I just thought of a semi-realistic use-case :

Re: [PATCH/RFC 0/5] add unset.variable for unsetting previously set variables

2014-10-07 Thread Jakub Narębski
Junio C Hamano wrote: - [config] safe = section.variable will list variables that can be included with the config.safeInclude mechanism. Any variable that is not marked as config.safe that appears in the file included by the config.safeInclude mechanism will be ignored. Why

Re: [PATCH/RFC 0/5] add unset.variable for unsetting previously set variables

2014-10-07 Thread Junio C Hamano
Jakub Narębski jna...@gmail.com writes: Junio C Hamano wrote: - [config] safe = section.variable will list variables that can be included with the config.safeInclude mechanism. Any variable that is not marked as config.safe that appears in the file included by the

Re: [PATCH/RFC 0/5] add unset.variable for unsetting previously set variables

2014-10-07 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: Jakub Narębski jna...@gmail.com writes: Junio C Hamano wrote: - [config] safe = section.variable will list variables that can be included with the config.safeInclude mechanism. Any variable that is not marked as config.safe that appears

[PATCH/RFC 0/5] add unset.variable for unsetting previously set variables

2014-10-02 Thread Tanay Abhra
Hi, This series aims to add a method to filter previously set variables. The patch series can be best described by the 3/5 log message which I have pasted below verbatim. Add a new config variable unset.variable which unsets previously set variables. It affects `git_config()` and

Re: [PATCH/RFC 0/5] add unset.variable for unsetting previously set variables

2014-10-02 Thread Junio C Hamano
Tanay Abhra tanay...@gmail.com writes: (just this point quick) 1 The name of the variable, I could not decide between unset.variable and config.unset, or may be some other name would be more appropriate. I'd prefer to see this as [config] something. I wish we did the include as [config]

Re: [PATCH/RFC 0/5] add unset.variable for unsetting previously set variables

2014-10-02 Thread Junio C Hamano
Tanay Abhra tanay...@gmail.com writes: 2 It affects both the C git_config() calls and, git config shell invocations. Due to this some variables may be absent from the git config -l result which might confuse the user. I am not sure what you mean by this. If you process variable definitions

Re: [PATCH/RFC 0/5] add unset.variable for unsetting previously set variables

2014-10-02 Thread Jeff King
On Thu, Oct 02, 2014 at 12:29:14PM -0700, Junio C Hamano wrote: Tanay Abhra tanay...@gmail.com writes: (just this point quick) 1 The name of the variable, I could not decide between unset.variable and config.unset, or may be some other name would be more appropriate. I'd prefer to