Re: [PATCH/RFC 2/6] remote-curl.c: fix variable shadowing

On Mon, 2016-04-18 at 11:35 -0700, Junio C Hamano wrote: > David Turner writes: > > > The local variable 'options' was shadowing a global of the same > > name. > > > > Signed-off-by: David Turner > > --- > > OK. In general, giving a longer

Re: [PATCH/RFC 2/6] remote-curl.c: fix variable shadowing

David Turner writes: > The local variable 'options' was shadowing a global of the same name. > > Signed-off-by: David Turner > --- OK. In general, giving a longer and more descriptive name to the global would be a direction to lead to more

[PATCH/RFC 2/6] remote-curl.c: fix variable shadowing

The local variable 'options' was shadowing a global of the same name. Signed-off-by: David Turner --- remote-curl.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/remote-curl.c b/remote-curl.c index 15e48e2..b9b6a90 100644 ---