Re: [PATCH/RFC v2 04/16] Modify write functions to prepare for other index formats

2012-08-07 Thread Thomas Gummerer
On 08/05, Junio C Hamano wrote: > Thomas Gummerer writes: > > > -static int ce_write(git_SHA_CTX *context, int fd, void *data, unsigned int > > len) > > +static int ce_write_v2(git_SHA_CTX *context, int fd, void *data, unsigned > > int len) > > { > > Mild NAK to name this function with any

Re: [PATCH/RFC v2 04/16] Modify write functions to prepare for other index formats

2012-08-05 Thread Junio C Hamano
Thomas Gummerer writes: > -static int ce_write(git_SHA_CTX *context, int fd, void *data, unsigned int > len) > +static int ce_write_v2(git_SHA_CTX *context, int fd, void *data, unsigned > int len) > { Mild NAK to name this function with any hint that it is for v2 only. The type of "data" is n

[PATCH/RFC v2 04/16] Modify write functions to prepare for other index formats

2012-08-05 Thread Thomas Gummerer
Modify the write_index function to add the possibility to add other index formats, that are written in a different way. Also mark all functions, which shall only be used with v2-v4 as v2 functions. Signed-off-by: Thomas Gummerer --- read-cache.c | 43 ---