Re: [PATCH/RFC v3 07/16] Add a symlink 'git-remote-svn' in base dir.
On Tuesday 14 August 2012 13:46:43 Junio C Hamano wrote: Florian Achleitner florian.achleitner.2.6...@gmail.com writes: Allow execution of git-remote-svn even if the binary currently is located in contrib/svn-fe/. Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com --- git-remote-svn |1 + 1 file changed, 1 insertion(+) create mode 12 git-remote-svn diff --git a/git-remote-svn b/git-remote-svn new file mode 12 index 000..d3b1c07 --- /dev/null +++ b/git-remote-svn @@ -0,0 +1 @@ +contrib/svn-fe/remote-svn \ No newline at end of file Please scratch my previous comment. I thought you were adding an entry to .gitignore or something. I'd rather not to see such a symbolic link that points at a build product in the source tree. Making a symlink from the toplevel Makefile _after_ we built it in contrib/svn-fe/ (and removing it upon make clean) is OK, though. As with the makefile in contrib/svn-fe, this is just a hack. The toplevel Makefile doesn't seem to build contrib/* at all. I always need to call make explicitly in these subdirs. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH/RFC v3 07/16] Add a symlink 'git-remote-svn' in base dir.
Florian Achleitner florian.achleitner.2.6...@gmail.com writes: Allow execution of git-remote-svn even if the binary currently is located in contrib/svn-fe/. Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com --- git-remote-svn |1 + 1 file changed, 1 insertion(+) create mode 12 git-remote-svn diff --git a/git-remote-svn b/git-remote-svn new file mode 12 index 000..d3b1c07 --- /dev/null +++ b/git-remote-svn @@ -0,0 +1 @@ +contrib/svn-fe/remote-svn \ No newline at end of file Not paying enough attention to the patch you are sending? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH/RFC v3 07/16] Add a symlink 'git-remote-svn' in base dir.
Florian Achleitner florian.achleitner.2.6...@gmail.com writes: Allow execution of git-remote-svn even if the binary currently is located in contrib/svn-fe/. Signed-off-by: Florian Achleitner florian.achleitner.2.6...@gmail.com --- git-remote-svn |1 + 1 file changed, 1 insertion(+) create mode 12 git-remote-svn diff --git a/git-remote-svn b/git-remote-svn new file mode 12 index 000..d3b1c07 --- /dev/null +++ b/git-remote-svn @@ -0,0 +1 @@ +contrib/svn-fe/remote-svn \ No newline at end of file Please scratch my previous comment. I thought you were adding an entry to .gitignore or something. I'd rather not to see such a symbolic link that points at a build product in the source tree. Making a symlink from the toplevel Makefile _after_ we built it in contrib/svn-fe/ (and removing it upon make clean) is OK, though. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html