Re: [PATCH/RFH 0/3] stable priority-queue

2014-07-21 Thread Jeff King
On Mon, Jul 14, 2014 at 01:02:56PM +0200, David Kastrup wrote: > Jeff King writes: > > > As Junio and I discussed earlier in [1], this series makes the > > prio_queue struct stable with respect to object insertion (which in turn > > means we can use it to replace commit_list in more places). >

Re: [PATCH/RFH 0/3] stable priority-queue

2014-07-14 Thread David Kastrup
Jeff King writes: > As Junio and I discussed earlier in [1], this series makes the > prio_queue struct stable with respect to object insertion (which in turn > means we can use it to replace commit_list in more places). I don't think that this makes sense in general since it assumes the appropri

Re: [PATCH/RFH 0/3] stable priority-queue

2014-07-14 Thread Duy Nguyen
On Mon, Jul 14, 2014 at 12:40 PM, Jeff King wrote: > As Junio and I discussed earlier in [1], this series makes the > prio_queue struct stable with respect to object insertion (which in turn > means we can use it to replace commit_list in more places). > > I think everything here is correct, but t

[PATCH/RFH 0/3] stable priority-queue

2014-07-13 Thread Jeff King
As Junio and I discussed earlier in [1], this series makes the prio_queue struct stable with respect to object insertion (which in turn means we can use it to replace commit_list in more places). I think everything here is correct, but the second commit fails the final test in t5539. I think the t