Re: [PATCH][Outreachy] remove all the inclusions of git-compat-util.h in header files

Christian Couder writes: > So I think one solution to this problem is already proposed on our web site. OK, that's a good start. The next step is to make those who are involved in these education programs to be more aware of it ;-)

Re: [PATCH][Outreachy] remove all the inclusions of git-compat-util.h in header files

On Wed, Oct 10, 2018 at 10:46 AM Junio C Hamano wrote: > > Johannes Schindelin writes: > > > Personally, I find the "whoever is picking it up should do the thinking" > > much too harsh for a first-time contributor who specifically came through > > the Outreachy program, i.e. expected to have a

Re: [PATCH][Outreachy] remove all the inclusions of git-compat-util.h in header files

Johannes Schindelin writes: > Personally, I find the "whoever is picking it up should do the thinking" > much too harsh for a first-time contributor who specifically came through > the Outreachy program, i.e. expected to have a gentle introduction into > the project, and into the ways we work.

Re: [PATCH][Outreachy] remove all the inclusions of git-compat-util.h in header files

Hi Junio & Ananya, Ananya, I think you did a really good job at contributing your first patch, demonstrated by the useful comments you already received. On Tue, 9 Oct 2018, Junio C Hamano wrote: > Derrick Stolee writes: > > > On 10/8/2018 1:05 PM, Ananya Krishna Maram wrote: > >> Hi All, > >

Re: [PATCH][Outreachy] remove all the inclusions of git-compat-util.h in header files

Derrick Stolee writes: > On 10/8/2018 1:05 PM, Ananya Krishna Maram wrote: >> Hi All, > Hello, Ananya! Welcome. > >> I was searching through #leftovers and found this. >> https://public-inbox.org/git/cabpp-bgvvxcbzx44er6to-pusfen_6gnyj1u5cuon9deaa4...@mail.gmail.com/ >> >> This patch address the

Re: [PATCH][Outreachy] remove all the inclusions of git-compat-util.h in header files

On Mon, 8 Oct 2018 at 22:43, Derrick Stolee wrote: > > On 10/8/2018 1:05 PM, Ananya Krishna Maram wrote: > > Hi All, > Hello, Ananya! Welcome. > > > I was searching through #leftovers and found this. > >

Re: [PATCH][Outreachy] remove all the inclusions of git-compat-util.h in header files

On 10/8/2018 1:05 PM, Ananya Krishna Maram wrote: Hi All, Hello, Ananya! Welcome. I was searching through #leftovers and found this. https://public-inbox.org/git/cabpp-bgvvxcbzx44er6to-pusfen_6gnyj1u5cuon9deaa4...@mail.gmail.com/ This patch address the task discussed in the above link. The

[PATCH][Outreachy] remove all the inclusions of git-compat-util.h in header files

Hi All, I was searching through #leftovers and found this. https://public-inbox.org/git/cabpp-bgvvxcbzx44er6to-pusfen_6gnyj1u5cuon9deaa4...@mail.gmail.com/ This patch address the task discussed in the above link. From: Ananya Krishan Maram skip the #include of git-compat-util.h since all .c