Re: [PATCH] Add fetch.recurseSubmoduleParallelism config option

2015-10-16 Thread Junio C Hamano
Stefan Beller writes: > so maybe > fetch.recurseSubmoduleJobs > fetch.submoduleJobs > fetch.jobs > fetch.connectionsToUse "git remote update" is another example that may want to run multiple independent 'git fetch' in parallel. I think "When the operation I

Re: [PATCH] Add fetch.recurseSubmoduleParallelism config option

2015-10-16 Thread Stefan Beller
On Mon, Oct 12, 2015 at 4:50 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> There is core.preloadIndex to enable parallel index preload, but >> that is boolean and not giving fine control to the user. We want to give >> fine control to the user here

Re: [PATCH] Add fetch.recurseSubmoduleParallelism config option

2015-10-13 Thread Junio C Hamano
Stefan Beller writes: >> The parallel_process API could learn a new "verbose" feature that it >> by itself shows some messages like >> >> "processing the 'frotz' job with N tasks" >> "M tasks finished (N still running)" > > I know what to fill in for M and N, 'frotz'

Re: [PATCH] Add fetch.recurseSubmoduleParallelism config option

2015-10-13 Thread Stefan Beller
On Tue, Oct 13, 2015 at 12:32 AM, Junio C Hamano wrote: > Stefan Beller writes: > >>> The parallel_process API could learn a new "verbose" feature that it >>> by itself shows some messages like >>> >>> "processing the 'frotz' job with N tasks" >>>

Re: [PATCH] Add fetch.recurseSubmoduleParallelism config option

2015-10-13 Thread Junio C Hamano
Stefan Beller writes: > Assuming we go with your second school of thought (N are the real > running processes, M including the finished but still pending output tasks), That's neither of my two, I would think. Anyway, I think it is now clear that it not very easy to say "I

Re: [PATCH] Add fetch.recurseSubmoduleParallelism config option

2015-10-12 Thread Stefan Beller
On Mon, Oct 12, 2015 at 4:14 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> This allows to configure fetching in parallel without having the annoying >> command line option. > > s/annoying//; > > I think this is a sane thing to do, but the name of

Re: [PATCH] Add fetch.recurseSubmoduleParallelism config option

2015-10-12 Thread Junio C Hamano
Stefan Beller writes: > This allows to configure fetching in parallel without having the annoying > command line option. s/annoying//; I think this is a sane thing to do, but the name of the variable may want to be bikeshedded a bit. > This moved the responsibility to

[PATCH] Add fetch.recurseSubmoduleParallelism config option

2015-10-12 Thread Stefan Beller
This allows to configure fetching in parallel without having the annoying command line option. This moved the responsibility to determine how many parallel processes to start from builtin/fetch to submodule.c as we need a way to communicate "The user did not specify the number of parallel

Re: [PATCH] Add fetch.recurseSubmoduleParallelism config option

2015-10-12 Thread Junio C Hamano
Stefan Beller writes: > There is core.preloadIndex to enable parallel index preload, but > that is boolean and not giving fine control to the user. We want to give > fine control to the user here I'd assume. I'd approach this as "fetching multiple submodules at a time", if I