Re: [PATCH] Change configure to check if pthreads are usable without any extra flags

2012-07-09 Thread Max Horn
On 09.07.2012, at 16:50, Junio C Hamano wrote: Max Horn m...@quendi.de writes: The configure script checks whether certain flags / libraries are required to use pthreads. But so far it did not consider the possibility that no extra compiler flags are needed (as is the case on Mac OS X). As

Re: [PATCH] Change configure to check if pthreads are usable without any extra flags

2012-07-09 Thread Junio C Hamano
Max Horn m...@quendi.de writes: diff --git a/configure.ac b/configure.ac index 4e9012f..d767ef3 100644 --- a/configure.ac +++ b/configure.ac @@ -1002,7 +1002,7 @@ if test -n $USER_NOPTHREAD; then # -D_REENTRANT' or some such. elif test -z $PTHREAD_CFLAGS; then threads_found=no - for

Re: [PATCH] Change configure to check if pthreads are usable without any extra flags

2012-07-09 Thread Max Horn
On 09.07.2012, at 19:44, Junio C Hamano wrote: Max Horn m...@quendi.de writes: diff --git a/configure.ac b/configure.ac index 4e9012f..d767ef3 100644 --- a/configure.ac +++ b/configure.ac @@ -1002,7 +1002,7 @@ if test -n $USER_NOPTHREAD; then # -D_REENTRANT' or some such. elif test -z

Re: [PATCH] Change configure to check if pthreads are usable without any extra flags

2012-07-09 Thread Junio C Hamano
Max Horn m...@quendi.de writes: would it be feasible for the purpose of the check to tweak the definition of works used in the loop so that it considers the warning as not working? That would be possible, and probably a good idea. But it is also completely orthogonal to my patch. Indeed, if

Re: [PATCH] Change configure to check if pthreads are usable without any extra flags

2012-07-09 Thread Max Horn
On 09.07.2012, at 21:23, Junio C Hamano wrote: Max Horn m...@quendi.de writes: would it be feasible for the purpose of the check to tweak the definition of works used in the loop so that it considers the warning as not working? That would be possible, and probably a good idea. But it is

Re: [PATCH] Change configure to check if pthreads are usable without any extra flags

2012-07-09 Thread Junio C Hamano
Max Horn m...@quendi.de writes: But all in all, I don't understand why this order independence seems to be so important? Not so important as long as it is made clear for later people to patch that part of the code. I just wanted to make sure that somebody thought hard enough to judge that it