Re: [PATCH] CodingGuidelines: mention "static" and "extern"

2018-02-09 Thread Jeff King
On Fri, Feb 09, 2018 at 11:07:38AM -0800, Jonathan Tan wrote: > On Thu, 8 Feb 2018 18:14:06 -0500 > Eric Sunshine wrote: > > > On Thu, Feb 8, 2018 at 4:38 PM, Jeff King wrote: > > > Subject: [PATCH] CodingGuidelines: mention "static" and "extern"

Re: [PATCH] CodingGuidelines: mention "static" and "extern"

2018-02-09 Thread Jonathan Tan
On Thu, 8 Feb 2018 18:14:06 -0500 Eric Sunshine wrote: > On Thu, Feb 8, 2018 at 4:38 PM, Jeff King wrote: > > Subject: [PATCH] CodingGuidelines: mention "static" and "extern" > > [...] > > > > Signed-off-by: Jeff King > > --- > >

Re: [PATCH] CodingGuidelines: mention "static" and "extern"

2018-02-08 Thread Eric Sunshine
On Thu, Feb 8, 2018 at 4:38 PM, Jeff King wrote: > Subject: [PATCH] CodingGuidelines: mention "static" and "extern" > [...] > > Signed-off-by: Jeff King > --- > diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines > @@ -386,6 +386,

Re: [PATCH] CodingGuidelines: mention "static" and "extern"

2018-02-08 Thread Stefan Beller
hating it for > almost 12 years now. ;) > >> $ cat Documentation/CodingGuidelines |grep extern >> $ # oh no it's empty! >> >> Care to add a section to our coding guidelines? > > Here's a patch. > > -- >8 -- > Subject: [PATCH] CodingGuidelin

[PATCH] CodingGuidelines: mention "static" and "extern"

2018-02-08 Thread Jeff King
t's empty! > > Care to add a section to our coding guidelines? Here's a patch. -- >8 -- Subject: [PATCH] CodingGuidelines: mention "static" and "extern" It perhaps goes without saying that file-local stuff should be marked static, but it does not hurt to