Re: [PATCH] Fixes handling of --reference argument.

2012-10-25 Thread Jeff King
On Wed, Oct 24, 2012 at 09:52:52PM -0700, sza...@google.com wrote: Signed-off-by: Stefan Zager sza...@google.com --- git-submodule.sh |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/git-submodule.sh b/git-submodule.sh index ab6b110..dcceb43 100755 ---

Re: [PATCH] Fixes handling of --reference argument.

2012-10-25 Thread W. Trevor King
On Thu, Oct 25, 2012 at 04:36:26AM -0400, Jeff King wrote: On Wed, Oct 24, 2012 at 09:52:52PM -0700, sza...@google.com wrote: diff --git a/git-submodule.sh b/git-submodule.sh index ab6b110..dcceb43 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -270,7 +270,6 @@ cmd_add()

Re: [PATCH] Fixes handling of --reference argument.

2012-10-25 Thread Jeff King
On Thu, Oct 25, 2012 at 11:32:29PM +0200, Jens Lehmann wrote: @@ -270,7 +270,6 @@ cmd_add() ;; --reference=*) reference=$1 - shift ;; Is that right? We'll unconditionally do a shift at the end of the