Re: [PATCH] Makefile: replace perl/Makefile.PL with simple make rules

2017-12-21 Thread Alex Vandiver
On Thu, 30 Nov 2017, Jeff King wrote: > On Wed, Nov 29, 2017 at 07:54:30PM +, Ævar Arnfjörð Bjarmason wrote: > > > Replace the perl/Makefile.PL and the fallback perl/Makefile used under > > NO_PERL_MAKEMAKER=NoThanks with a much simpler implementation heavily > > inspired by how the i18n infra

Re: [PATCH] Makefile: replace perl/Makefile.PL with simple make rules

2017-11-30 Thread Ævar Arnfjörð Bjarmason
On Thu, Nov 30 2017, Jeff King jotted: > On Wed, Nov 29, 2017 at 07:54:30PM +, Ævar Arnfjörð Bjarmason wrote: > >> Replace the perl/Makefile.PL and the fallback perl/Makefile used under >> NO_PERL_MAKEMAKER=NoThanks with a much simpler implementation heavily >> inspired by how the i18n infras

Re: [PATCH] Makefile: replace perl/Makefile.PL with simple make rules

2017-11-30 Thread Jeff King
On Wed, Nov 29, 2017 at 07:54:30PM +, Ævar Arnfjörð Bjarmason wrote: > Replace the perl/Makefile.PL and the fallback perl/Makefile used under > NO_PERL_MAKEMAKER=NoThanks with a much simpler implementation heavily > inspired by how the i18n infrastructure's build process works[1]. I'm very ha

Re: [PATCH] Makefile: replace perl/Makefile.PL with simple make rules

2017-11-30 Thread Eric Wong
Jonathan Nieder wrote: > Yeah, people really do use Git.pm as an external API. Yikes :< > If we want to prevent this, then we should not be installing it in the > public perl module path. Or we should at least add a note to the > manpages we ship :) to recommend not using it. I think a note in

Re: [PATCH] Makefile: replace perl/Makefile.PL with simple make rules

2017-11-30 Thread Jonathan Nieder
Ævar Arnfjörð Bjarmason wrote: > On Thu, Nov 30 2017, Jonathan Nieder jotted: >> Ævar Arnfjörð Bjarmason wrote: >>> * We don't build the Git(3) Git::I18N(3) etc. man pages from the >>>embedded perldoc. I suspect nobody really cares, these are mostly >>>internal APIs, and if someone's deve

Re: [PATCH] Makefile: replace perl/Makefile.PL with simple make rules

2017-11-30 Thread Ævar Arnfjörð Bjarmason
On Thu, Nov 30 2017, Jonathan Nieder jotted: > Hi, > > Ævar Arnfjörð Bjarmason wrote: > >> Replace the perl/Makefile.PL and the fallback perl/Makefile used under >> NO_PERL_MAKEMAKER=NoThanks with a much simpler implementation heavily >> inspired by how the i18n infrastructure's build process wor

Re: [PATCH] Makefile: replace perl/Makefile.PL with simple make rules

2017-11-29 Thread Jonathan Nieder
Hi, Ævar Arnfjörð Bjarmason wrote: > Replace the perl/Makefile.PL and the fallback perl/Makefile used under > NO_PERL_MAKEMAKER=NoThanks with a much simpler implementation heavily > inspired by how the i18n infrastructure's build process works[1]. Yay! This looks exciting. One quick comment:

[PATCH] Makefile: replace perl/Makefile.PL with simple make rules

2017-11-29 Thread Ævar Arnfjörð Bjarmason
Replace the perl/Makefile.PL and the fallback perl/Makefile used under NO_PERL_MAKEMAKER=NoThanks with a much simpler implementation heavily inspired by how the i18n infrastructure's build process works[1]. The reason for having the Makefile.PL in the first place is that it was initially[2] buildi