Re: [PATCH] Move test-* to t/helper/ subdirectory

2016-05-10 Thread Junio C Hamano
Duy Nguyen writes: > Or a simpler, more-to-the-point patch like this? I am OK with that, even though I find it a bit too "cute" for my taste. > -- 8< -- > Subject: [PATCH] wrap-for-bin.sh: regenerate bin-wrappers when switching > branches > > Commit e6e7530 (test helpers:

Re: [PATCH] Move test-* to t/helper/ subdirectory

2016-05-10 Thread Duy Nguyen
On Mon, May 09, 2016 at 09:03:44AM -0700, Junio C Hamano wrote: > Duy Nguyen writes: > > > So among the options we have so far, which way should we go, or leave it as > > is? > > Thanks for reminding me. > > I like that version you sent with "I may have rushed to judgment"

Re: [PATCH] Move test-* to t/helper/ subdirectory

2016-05-09 Thread Junio C Hamano
Duy Nguyen writes: > So among the options we have so far, which way should we go, or leave it as > is? Thanks for reminding me. I like that version you sent with "I may have rushed to judgment" comment the most. Perhaps I can just queue it with s/PATH/PROG/ fixup? > > On

Re: [PATCH] Move test-* to t/helper/ subdirectory

2016-05-08 Thread Duy Nguyen
So among the options we have so far, which way should we go, or leave it as is? On Tue, May 3, 2016 at 7:15 AM, Duy Nguyen wrote: > On Tue, May 3, 2016 at 12:34 AM, Junio C Hamano wrote: >> Duy Nguyen writes: >> >>> I may have rushed to

Re: [PATCH] Move test-* to t/helper/ subdirectory

2016-05-02 Thread Duy Nguyen
On Tue, May 3, 2016 at 12:34 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> I may have rushed to judgement. wrap-for-bin.sh has always been the >> dependency for bin-wrappers/*. If we force that file to change, then >> bin-wrappers/* will be recreated

Re: [PATCH] Move test-* to t/helper/ subdirectory

2016-05-02 Thread Junio C Hamano
Duy Nguyen writes: > I may have rushed to judgement. wrap-for-bin.sh has always been the > dependency for bin-wrappers/*. If we force that file to change, then > bin-wrappers/* will be recreated when switching branches. So how about > this? I do not think you are "force

Re: [PATCH] Move test-* to t/helper/ subdirectory

2016-05-01 Thread Duy Nguyen
On Sun, May 01, 2016 at 07:28:52AM +0700, Duy Nguyen wrote: > On Wed, Apr 27, 2016 at 09:15:41AM -0700, Junio C Hamano wrote: > > Duy Nguyen writes: > > > > > This patch forces bin-wrappers regeneration every time a test program > > > is updated. A bit wasteful, but I don't

Re: [PATCH] Move test-* to t/helper/ subdirectory

2016-04-30 Thread Duy Nguyen
On Wed, Apr 27, 2016 at 09:15:41AM -0700, Junio C Hamano wrote: > Duy Nguyen writes: > > > This patch forces bin-wrappers regeneration every time a test program > > is updated. A bit wasteful, but I don't see a better option (which is > > also why I limit this to test programs

Re: [PATCH] Move test-* to t/helper/ subdirectory

2016-04-27 Thread Junio C Hamano
Duy Nguyen writes: > This patch forces bin-wrappers regeneration every time a test program > is updated. A bit wasteful, but I don't see a better option (which is > also why I limit this to test programs only). In other words, when we update the location where the programs

Re: [PATCH] Move test-* to t/helper/ subdirectory

2016-04-27 Thread Duy Nguyen
On Wed, Apr 27, 2016 at 07:52:41AM +0700, Duy Nguyen wrote: > > Can you (or somebody else) double check that the resulting Makefile > > gets the build dependencies and exec path right? > > > > I am seeing occasional failure from t0040 when checking out between > > master and pu, and between the

Re: [PATCH] Move test-* to t/helper/ subdirectory

2016-04-26 Thread Duy Nguyen
On Wed, Apr 27, 2016 at 5:07 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> This keeps top dir a bit less crowded. And because these programs are >> for testing purposes, it makes sense that they stay somewhere in t/ >> >> Signed-off-by:

Re: [PATCH] Move test-* to t/helper/ subdirectory

2016-04-26 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > This keeps top dir a bit less crowded. And because these programs are > for testing purposes, it makes sense that they stay somewhere in t/ > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > This patch will break any patches

Re: [PATCH] Move test-* to t/helper/ subdirectory

2016-04-15 Thread Duy Nguyen
On Sat, Apr 16, 2016 at 12:06 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Nguyễn Thái Ngọc Duy writes: >> >>> This keeps top dir a bit less crowded. And because these programs are >>> for testing purposes, it makes sense that

Re: [PATCH] Move test-* to t/helper/ subdirectory

2016-04-15 Thread Junio C Hamano
Junio C Hamano writes: > Nguyễn Thái Ngọc Duy writes: > >> This keeps top dir a bit less crowded. And because these programs are >> for testing purposes, it makes sense that they stay somewhere in t/ > > But leaves many *.o files after "make clean". Even

Re: [PATCH] Move test-* to t/helper/ subdirectory

2016-04-15 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > This keeps top dir a bit less crowded. And because these programs are > for testing purposes, it makes sense that they stay somewhere in t/ But leaves many *.o files after "make clean". Even "distclean" does not clean them. > > Signed-off-by:

[PATCH] Move test-* to t/helper/ subdirectory

2016-04-13 Thread Nguyễn Thái Ngọc Duy
This keeps top dir a bit less crowded. And because these programs are for testing purposes, it makes sense that they stay somewhere in t/ Signed-off-by: Nguyễn Thái Ngọc Duy --- This patch will break any patches that add new test programs. Luckily, none in 'next' or 'pu'