Re: [PATCH] alloc.c: remove alloc_raw_commit_node() function

2014-06-25 Thread Junio C Hamano
Jeff King writes: > For a while some people were compiling git with pretty antique > compilers, but I do not know if that is the case any more (Junio noted > recently that we have had trailing commas on arrays and enums in > builtin/clean.c for the past year, and nobody has complained). IIRC, th

Re: [PATCH] alloc.c: remove alloc_raw_commit_node() function

2014-06-19 Thread Ramsay Jones
On 19/06/14 10:19, Jeff King wrote: > On Wed, Jun 18, 2014 at 11:30:50PM +0100, Ramsay Jones wrote: > >> So, the patch below is a slight variation on the original patch. >> I'm still slightly concerned about portability, but given that it >> has been at least a decade since I last used a (pre-ANSI

Re: [PATCH] alloc.c: remove alloc_raw_commit_node() function

2014-06-19 Thread Jeff King
On Wed, Jun 18, 2014 at 11:30:50PM +0100, Ramsay Jones wrote: > So, the patch below is a slight variation on the original patch. > I'm still slightly concerned about portability, but given that it > has been at least a decade since I last used a (pre-ANSI) compiler > which had a problem with this

Re: [PATCH] alloc.c: remove alloc_raw_commit_node() function

2014-06-18 Thread Ramsay Jones
On 18/06/14 21:08, Jeff King wrote: > On Wed, Jun 18, 2014 at 08:52:46PM +0100, Ramsay Jones wrote: > [snip] > Yeah, I noticed it while writing the patch but decided it wasn't worth > the trouble to deal with (since after all, it's not advertised to any > callers, the very thing that sparse is com

Re: [PATCH] alloc.c: remove alloc_raw_commit_node() function

2014-06-18 Thread Jeff King
On Wed, Jun 18, 2014 at 08:52:46PM +0100, Ramsay Jones wrote: > In order to encapsulate the setting of the unique commit index, commit > 969eba63 ("commit: push commit_index update into alloc_commit_node", > 10-06-2014) introduced a (logically private) intermediary allocator > function. However, t

[PATCH] alloc.c: remove alloc_raw_commit_node() function

2014-06-18 Thread Ramsay Jones
In order to encapsulate the setting of the unique commit index, commit 969eba63 ("commit: push commit_index update into alloc_commit_node", 10-06-2014) introduced a (logically private) intermediary allocator function. However, this function (alloc_raw_commit_node()) was declared as a public functio