Re: [PATCH] cache-tree: remove use of strbuf_addf in update_one

2017-08-14 Thread Junio C Hamano
Jeff King writes: > On Thu, Aug 10, 2017 at 11:58:34AM -0700, Stefan Beller wrote: > >> On Thu, Aug 10, 2017 at 11:47 AM, Kevin Willford >> wrote: >> > String formatting can be a performance issue when there are >> > hundreds of thousands of trees. >> >>

Re: [PATCH] cache-tree: remove use of strbuf_addf in update_one

2017-08-11 Thread René Scharfe
Am 10.08.2017 um 20:47 schrieb Kevin Willford: > String formatting can be a performance issue when there are > hundreds of thousands of trees. > > Change to stop using the strbuf_addf and just add the strings > or characters individually. > > There are a limited number of modes so added a switch

Re: [PATCH] cache-tree: remove use of strbuf_addf in update_one

2017-08-10 Thread Stefan Beller
On Thu, Aug 10, 2017 at 12:57 PM, Kevin Willford wrote: > Here are some of the performance numbers from the windows repo. > I will work on writing a perf test for this change so that we > have a better idea on smaller repo what the impact of this change > is on them. > >

Re: [PATCH] cache-tree: remove use of strbuf_addf in update_one

2017-08-10 Thread Kevin Willford
On 8/10/2017 3:03 PM, Jeff King wrote: On Thu, Aug 10, 2017 at 11:58:34AM -0700, Stefan Beller wrote: On Thu, Aug 10, 2017 at 11:47 AM, Kevin Willford wrote: String formatting can be a performance issue when there are hundreds of thousands of trees. When changing

Re: [PATCH] cache-tree: remove use of strbuf_addf in update_one

2017-08-10 Thread Jeff King
On Thu, Aug 10, 2017 at 11:58:34AM -0700, Stefan Beller wrote: > On Thu, Aug 10, 2017 at 11:47 AM, Kevin Willford wrote: > > String formatting can be a performance issue when there are > > hundreds of thousands of trees. > > When changing this for the sake of performance,

Re: [PATCH] cache-tree: remove use of strbuf_addf in update_one

2017-08-10 Thread Stefan Beller
On Thu, Aug 10, 2017 at 11:47 AM, Kevin Willford wrote: > String formatting can be a performance issue when there are > hundreds of thousands of trees. When changing this for the sake of performance, could you give an example (which kind of repository you need for this to

[PATCH] cache-tree: remove use of strbuf_addf in update_one

2017-08-10 Thread Kevin Willford
String formatting can be a performance issue when there are hundreds of thousands of trees. Change to stop using the strbuf_addf and just add the strings or characters individually. There are a limited number of modes so added a switch for the known ones and a default case if something comes