On Sat, Sep 08, 2012 at 04:10:59PM +0200, Robin Stocker wrote:
> > > Maybe the solution is to detect if the original commit message
> > > ends with a trailer and in that case keep the existing behavior
> > > of not inserting a blank line?
> >
> > Yeah, that sounds like a good change from "this ma
Junio C Hamano writes:
> Robin Stocker writes:
>
> > Junio C Hamano writes:
> >> Robin Stocker writes:
> >>
> >> > if (opts->record_origin) {
> >> > + /* Some implementations don't terminate message with final \n,
> >> > so
> >> > add it */
> >> > + if (msg.message[strlen(msg.me
Robin Stocker writes:
> Junio C Hamano writes:
>> Robin Stocker writes:
>>
>> >if (opts->record_origin) {
>> > + /* Some implementations don't terminate message with final \n, so
>> > add it */
>> > + if (msg.message[strlen(msg.message)-1] != '\n')
>> > + strbuf_addch(&msgbuf, '\n')
Junio C Hamano writes:
> Robin Stocker writes:
>
> > if (opts->record_origin) {
> > + /* Some implementations don't terminate message with final \n, so
> > add it */
> > + if (msg.message[strlen(msg.message)-1] != '\n')
> > + strbuf_addch(&msgbuf, '\n');
>
> I can agree that this is
Robin Stocker writes:
> if (opts->record_origin) {
> + /* Some implementations don't terminate message with
> final \n, so add it */
> + if (msg.message[strlen(msg.message)-1] != '\n')
> + strbuf_addch(&msgbuf, '\n
Before this, git cherry-pick -x resulted in messages like this:
Message of cherry-picked commit
(cherry picked from commit 871e293c9acbeaacce59dcd98fab6028f552f5be)
Which is not the recommended way to write commit messages. When the
commit message ends with a Signed-off-by, it's less bad.
6 matches
Mail list logo