Re: [PATCH] clean up confusing suggestion for commit references

2016-10-11 Thread Heiko Voigt
On Mon, Oct 10, 2016 at 12:14:14PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > On Mon, Oct 10, 2016 at 11:24:01AM -0700, Junio C Hamano wrote: > > > >> I no longer have preference either way myself, even though I was in > >> favor of no-quotes simply because I had an

Re: [PATCH] clean up confusing suggestion for commit references

2016-10-10 Thread Junio C Hamano
Jeff King writes: > On Mon, Oct 10, 2016 at 11:24:01AM -0700, Junio C Hamano wrote: > >> I no longer have preference either way myself, even though I was in >> favor of no-quotes simply because I had an alias to produce that >> format and was used to it. > > I'll admit that I

Re: [PATCH] clean up confusing suggestion for commit references

2016-10-10 Thread Jeff King
On Mon, Oct 10, 2016 at 11:24:01AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > On Fri, Oct 07, 2016 at 11:56:38AM +0200, Heiko Voigt wrote: > > > >> The description for referencing commits looks as if it is contradicting > >> the example, since it is itself enclosed in

Re: [PATCH] clean up confusing suggestion for commit references

2016-10-10 Thread Junio C Hamano
Jeff King writes: > On Fri, Oct 07, 2016 at 11:56:38AM +0200, Heiko Voigt wrote: > >> The description for referencing commits looks as if it is contradicting >> the example, since it is itself enclosed in double quotes. Lets use >> single quotes around the description and include

Re: [PATCH] clean up confusing suggestion for commit references

2016-10-10 Thread Junio C Hamano
Heiko Voigt writes: > If you want to reference a previous commit in the history of a stable > -branch, use the format "abbreviated sha1 (subject, date)", > +branch, use the format 'abbreviated sha1 ("subject", date)', > with the subject enclosed in a pair of double-quotes,

Re: [PATCH] clean up confusing suggestion for commit references

2016-10-07 Thread Jeff King
On Fri, Oct 07, 2016 at 11:56:38AM +0200, Heiko Voigt wrote: > The description for referencing commits looks as if it is contradicting > the example, since it is itself enclosed in double quotes. Lets use > single quotes around the description and include the double quotes in > the description so

[PATCH] clean up confusing suggestion for commit references

2016-10-07 Thread Heiko Voigt
The description for referencing commits looks as if it is contradicting the example, since it is itself enclosed in double quotes. Lets use single quotes around the description and include the double quotes in the description so it matches the example. --- Sorry for opening this up again but I