Re* [PATCH] commit: make default of cleanup option configurable

2013-01-10 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: I also wonder, as a longer term alternative (which would require a lot of code auditing and some refactoring), if it is useful to have an option and/or configuration that lets you configure the comment in log message editor character from the default #

Re: [PATCH] commit: make default of cleanup option configurable

2013-01-09 Thread Ralf Thielow
Hi, 2013/1/9 Jonathan Nieder jrnie...@gmail.com: Hi, Ralf Thielow wrote: The default of the cleanup option in git commit is not configurable. Users who don't want to use the default have to pass this option on every commit since there's no way to configure it. Could you give an example?

Re: [PATCH] commit: make default of cleanup option configurable

2013-01-09 Thread Jonathan Nieder
Ralf Thielow wrote: It's actually my own usecase :). The bugtracker I'm using is able to create relationships between issues and related commits. It expects that a part of the commit message contains the issue number in format #issueId. So I need to use a cleanup mode different from default

Re: [PATCH] commit: make default of cleanup option configurable

2013-01-09 Thread Junio C Hamano
Ralf Thielow ralf.thie...@gmail.com writes: When a user uses a script/importer which expects that the default option is used without setting it explicitly, and then the user changes the default, isn't it the users fault if that would break things? Not necessarily. There are many people who

Re: [PATCH] commit: make default of cleanup option configurable

2013-01-09 Thread Junio C Hamano
Ralf Thielow ralf.thie...@gmail.com writes: It's actually my own usecase :). The bugtracker I'm using is able to create relationships between issues and related commits. It expects that a part of the commit message contains the issue number in format #issueId. So I need to use a cleanup mode

[PATCH] commit: make default of cleanup option configurable

2013-01-08 Thread Ralf Thielow
The default of the cleanup option in git commit is not configurable. Users who don't want to use the default have to pass this option on every commit since there's no way to configure it. This commit introduces a new config option commit.cleanup which can be used to change the default of the

Re: [PATCH] commit: make default of cleanup option configurable

2013-01-08 Thread Junio C Hamano
Ralf Thielow ralf.thie...@gmail.com writes: The default of the cleanup option in git commit is not configurable. Users who don't want to use the default have to pass this option on every commit since there's no way to configure it. This commit introduces a new config option commit.cleanup

Re: [PATCH] commit: make default of cleanup option configurable

2013-01-08 Thread Jonathan Nieder
Hi, Ralf Thielow wrote: The default of the cleanup option in git commit is not configurable. Users who don't want to use the default have to pass this option on every commit since there's no way to configure it. Could you give an example? I'm trying to get a sense of whether these habitual