Re: [PATCH] commit & merge: modularize the empty message validator

Christian Brabandt writes: > On Do, 13 Jul 2017, Junio C Hamano wrote: > >> I think many people know about and do use the "delete all lines" >> (i.e. ":1,$d" in vi, or \M-< \C-SPC \M-> \C-w in Emacs) to abort out >> of a commit or a merge. I just do not think it is likely for

Re: [PATCH] commit & merge: modularize the empty message validator

On Do, 13 Jul 2017, Junio C Hamano wrote: > I think many people know about and do use the "delete all lines" > (i.e. ":1,$d" in vi, or \M-< \C-SPC \M-> \C-w in Emacs) to abort out > of a commit or a merge. I just do not think it is likely for them > to leave Sign-off lines and remove everything

Re: [PATCH] commit & merge: modularize the empty message validator

On Fri, 2017-07-14 at 23:19 +0530, Kaartic Sivaraam wrote: > * Imagine a hypothetical version of git that aborts when the > is empty though a  is present. This would > quite possibly instigate controversies as the "hypothetical git" > reduces the "valid commit

Re: [PATCH] commit & merge: modularize the empty message validator

On Thu, 2017-07-13 at 12:23 -0700, Junio C Hamano wrote: > All good points; if it bothers you that "commit" and "merge" define > "emptyness" of the buffer differently too much, I think you could > persuade me to unify them to "the buffer _must_ contain no bytes", > i.e. not special-casing sign-off

Re: [PATCH] commit & merge: modularize the empty message validator

On Thu, 2017-07-13 at 10:58 -0700, Junio C Hamano wrote: > I think many people know about and do use the "delete all lines" > (i.e. ":1,$d" in vi, or \M-< \C-SPC \M-> \C-w in Emacs) to abort out > of a commit or a merge.  I just do not think it is likely for them > to leave Sign-off lines and

Re: [PATCH] commit & merge: modularize the empty message validator

Kaartic Sivaraam writes: > I have a few doubts for which I need clarification to move on with > this. > > 1. If we abort when the part is empty wouldn't it be too > restrictive ? > > IOW, Wouldn't it affect users of "git commit -‍-cleanup=verbatim" >

Re: [PATCH] commit & merge: modularize the empty message validator

On Tue, 2017-07-11 at 13:22 -0700, Junio C Hamano wrote: > I think the "validation" done with the rest_is_empty() is somewhat > bogus.  Why should we reject a commit without a message and a > trailer block with only signed-off-by lines, while accepting a > commit without a message and a trailer

Re: [PATCH] commit & merge: modularize the empty message validator

Kaartic Sivaraam writes: > Sometimes I abort an commit from from the editor by providing an empty > commit message. Then I came to know that 'git commit' considers commit > messages with just signed-off-by lines as an empty message. I tried to > take advantage of

Re: [PATCH] commit & merge: modularize the empty message validator

On Tue, 2017-07-11 at 13:22 -0700, Junio C Hamano wrote: > Having said all that, I am not sure "Prevent such surprises" is a > problem that is realistic to begin with.  When a user sees the > editor buffer in "git merge", it is pre-populated with at least a > single line of message "Merge branch

Re: [PATCH] commit & merge: modularize the empty message validator

Kaartic Sivaraam writes: > In the context of "git merge" the meaning of an "empty message" > is one that contains no line of text. This is not in line with > "git commit" where an "empty message" is one that contains only > whitespaces and/or signed-off-by lines.

[PATCH] commit & merge: modularize the empty message validator

In the context of "git merge" the meaning of an "empty message" is one that contains no line of text. This is not in line with "git commit" where an "empty message" is one that contains only whitespaces and/or signed-off-by lines. This could cause surprises to users who are accustomed to the